]> git.hungrycats.org Git - linux/commitdiff
RDMA/rxe: Remove the unused variable obj
authorZhu Yanjun <yanjun.zhu@linux.dev>
Mon, 22 Aug 2022 01:16:15 +0000 (21:16 -0400)
committerLeon Romanovsky <leonro@nvidia.com>
Wed, 31 Aug 2022 06:53:13 +0000 (09:53 +0300)
The member variable obj in struct rxe_task is not needed.
So remove it to save memory.

Link: https://lore.kernel.org/r/20220822011615.805603-4-yanjun.zhu@linux.dev
Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Bob Pearson <rpearsonhpe@gmail.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/sw/rxe/rxe_qp.c
drivers/infiniband/sw/rxe/rxe_task.c
drivers/infiniband/sw/rxe/rxe_task.h

index d776dfda43b1616c7af7c321f1a4440b85910346..1dcbeacb31223a4ecdb7e3ec43500ef38b6042dd 100644 (file)
@@ -242,9 +242,9 @@ static int rxe_qp_init_req(struct rxe_dev *rxe, struct rxe_qp *qp,
 
        skb_queue_head_init(&qp->req_pkts);
 
-       rxe_init_task(rxe, &qp->req.task, qp,
+       rxe_init_task(&qp->req.task, qp,
                      rxe_requester, "req");
-       rxe_init_task(rxe, &qp->comp.task, qp,
+       rxe_init_task(&qp->comp.task, qp,
                      rxe_completer, "comp");
 
        qp->qp_timeout_jiffies = 0; /* Can't be set for UD/UC in modify_qp */
@@ -292,7 +292,7 @@ static int rxe_qp_init_resp(struct rxe_dev *rxe, struct rxe_qp *qp,
 
        skb_queue_head_init(&qp->resp_pkts);
 
-       rxe_init_task(rxe, &qp->resp.task, qp,
+       rxe_init_task(&qp->resp.task, qp,
                      rxe_responder, "resp");
 
        qp->resp.opcode         = OPCODE_NONE;
index 2248cf33d776670e7d5fea009a5e6f689da4f210..ec2b7de1c4972105e1552b2bf3c8190869ce86a8 100644 (file)
@@ -94,10 +94,9 @@ void rxe_do_task(struct tasklet_struct *t)
        task->ret = ret;
 }
 
-int rxe_init_task(void *obj, struct rxe_task *task,
+int rxe_init_task(struct rxe_task *task,
                  void *arg, int (*func)(void *), char *name)
 {
-       task->obj       = obj;
        task->arg       = arg;
        task->func      = func;
        snprintf(task->name, sizeof(task->name), "%s", name);
index 11d183fd333863d74a888dcfed916e14067b3150..7f612a1c68a7ba3c76d02aaa1fd5ee04c384a2bd 100644 (file)
@@ -19,7 +19,6 @@ enum {
  * called again.
  */
 struct rxe_task {
-       void                    *obj;
        struct tasklet_struct   tasklet;
        int                     state;
        spinlock_t              state_lock; /* spinlock for task state */
@@ -35,7 +34,7 @@ struct rxe_task {
  *     arg  => parameter to pass to fcn
  *     func => function to call until it returns != 0
  */
-int rxe_init_task(void *obj, struct rxe_task *task,
+int rxe_init_task(struct rxe_task *task,
                  void *arg, int (*func)(void *), char *name);
 
 /* cleanup task */