]> git.hungrycats.org Git - btrfs-progs/commitdiff
btrfs-progs: use full size path buffer in cmd_subvolume_delete()
authorDavid Sterba <dsterba@suse.com>
Thu, 23 Jul 2026 08:38:06 +0000 (10:38 +0200)
committerDavid Sterba <dsterba@suse.com>
Mon, 3 Aug 2026 10:59:15 +0000 (12:59 +0200)
Commit d544db2078fd43 ("btrfs-progs: unify naming of return values in
cmd_subvolume_create()") converted the unchecked sprintf to path API but
the full_subvolpath is actually shorter than PATH_MAX. This could lead
to stack overflow for a really long path.

Signed-off-by: David Sterba <dsterba@suse.com>
cmds/subvolume.c

index 746b493a613c867396322da5b92e202679780a06..7aeeba6d94289cb4246dc29f03ce561c5e356880 100644 (file)
@@ -345,7 +345,7 @@ static int cmd_subvolume_delete(const struct cmd_struct *cmd, int argc, char **a
        u8 fsid[BTRFS_FSID_SIZE];
        u64 subvolid = 0;
        char uuidbuf[BTRFS_UUID_UNPARSED_SIZE];
-       char full_subvolpath[BTRFS_SUBVOL_NAME_MAX];
+       char full_subvolpath[PATH_MAX];
        struct seen_fsid *seen_fsid_hash[SEEN_FSID_HASH_SIZE] = { NULL, };
        enum { COMMIT_AFTER = 1, COMMIT_EACH = 2 };
        enum btrfs_util_error err;