]> git.hungrycats.org Git - linux/commitdiff
clk: at91: usb: fix determine_rate prototype again
authorArnd Bergmann <arnd@arndb.de>
Fri, 21 Apr 2017 12:45:23 +0000 (14:45 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 30 Apr 2017 03:49:14 +0000 (05:49 +0200)
We had an incorrect backport of
4591243102fa ("clk: at91: usb: propagate rate modification to the parent clk")
that was fixed incorrectly in linux-3.18.y by
76723e7ed589 ("clk: at91: usb: fix determine_rate prototype")

as shown by this warning:

drivers/clk/at91/clk-usb.c:155:20: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
drivers/clk/at91/clk-usb.c:193:20: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]

This should fix it properly.

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/clk/at91/clk-usb.c

index 0283a5713d6c2e7804caf3b576c6397db8a0e771..930a424cc4a050efa4b3ec4645dc1b5fd979990b 100644 (file)
@@ -59,7 +59,7 @@ static unsigned long at91sam9x5_clk_usb_recalc_rate(struct clk_hw *hw,
 static long at91sam9x5_clk_usb_determine_rate(struct clk_hw *hw,
                                              unsigned long rate,
                                              unsigned long *best_parent_rate,
-                                             struct clk_hw **best_parent_hw)
+                                             struct clk **best_parent_hw)
 {
        struct clk *parent = NULL;
        long best_rate = -EINVAL;
@@ -91,7 +91,7 @@ static long at91sam9x5_clk_usb_determine_rate(struct clk_hw *hw,
                                best_rate = tmp_rate;
                                best_diff = tmp_diff;
                                *best_parent_rate = tmp_parent_rate;
-                               *best_parent_hw = __clk_get_hw(parent);
+                               *best_parent_hw = parent;
                        }
 
                        if (!best_diff || tmp_rate < rate)