]> git.hungrycats.org Git - linux/commitdiff
HID: elo: reject short touchscreen reports
authorJiale Yao <yaojiale02@163.com>
Thu, 24 Sep 2026 14:44:07 +0000 (22:44 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Nov 2026 17:10:50 +0000 (12:10 -0500)
commit 1cb92fcb2ac344d78737e3c5cb7b061dfb2850b1 upstream.

The HID core invokes raw_event callbacks before validating the report
length.  elo_raw_event() only checks the first-byte packet marker before
elo_process_data() reads coordinates, flags, and pressure through offset
seven.  A truncated packet beginning with the expected marker can therefore
cause an out-of-bounds read.

Require the complete eight-byte SmartSet packet before parsing it.

Commit 47669bec44fe ("HID: asus: refactor the two workqueues and init
sequence") added the same kind of raw_event length validation to hid-asus.

Fixes: d23efc19478a ("HID: add driver for ELO 4000/4500")
Cc: stable@vger.kernel.org
Signed-off-by: Jiale Yao <yaojiale02@163.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-elo.c

index b8f5f3eb53a4786622fd5b40482dae9445ddbaa8..86e8729e19758be519303d77c78260f17017494c 100644 (file)
@@ -85,6 +85,9 @@ static int elo_raw_event(struct hid_device *hdev, struct hid_report *report,
        if (!(hdev->claimed & HID_CLAIMED_INPUT) || list_empty(&hdev->inputs))
                return 0;
 
+       if (size < ELO_SMARTSET_PACKET_SIZE)
+               return 0;
+
        hidinput = list_first_entry(&hdev->inputs, struct hid_input, list);
 
        switch (report->id) {