]> git.hungrycats.org Git - linux/commitdiff
bnxt_en: fix clear flags in ethtool reset handling
authorScott Branden <scott.branden@broadcom.com>
Sat, 31 Mar 2018 17:54:09 +0000 (13:54 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 May 2018 06:17:24 +0000 (08:17 +0200)
[ Upstream commit 2373d8d6a7932d28b8e31ea2a70bf6c002d97ac8 ]

Clear flags when reset command processed successfully for components
specified.

Fixes: 6502ad5963a5 ("bnxt_en: Add ETH_RESET_AP support")
Signed-off-by: Scott Branden <scott.branden@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

index 9442605f4fd43bb2c36ef1a0a9b94c7cf39b3b7f..0b71d3b44933d2f225251a023e82ce49e23b8788 100644 (file)
@@ -2552,16 +2552,20 @@ static int bnxt_reset(struct net_device *dev, u32 *flags)
                        return -EOPNOTSUPP;
 
                rc = bnxt_firmware_reset(dev, BNXT_FW_RESET_CHIP);
-               if (!rc)
+               if (!rc) {
                        netdev_info(dev, "Reset request successful. Reload driver to complete reset\n");
+                       *flags = 0;
+               }
        } else if (*flags == ETH_RESET_AP) {
                /* This feature is not supported in older firmware versions */
                if (bp->hwrm_spec_code < 0x10803)
                        return -EOPNOTSUPP;
 
                rc = bnxt_firmware_reset(dev, BNXT_FW_RESET_AP);
-               if (!rc)
+               if (!rc) {
                        netdev_info(dev, "Reset Application Processor request successful.\n");
+                       *flags = 0;
+               }
        } else {
                rc = -EINVAL;
        }