]> git.hungrycats.org Git - linux/commitdiff
power: gpio-charger: balance enable/disable_irq_wake calls
authorDmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Thu, 15 Jan 2015 02:00:37 +0000 (05:00 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Mar 2015 22:43:26 +0000 (14:43 -0800)
commit faeed51bb65ce0241052d8dc24ac331ade12e976 upstream.

enable_irq_wakeup returns 0 in case it correctly enabled the IRQ to
generate the wakeup event (and thus resume should call disable_irq_wake).
Currently gpio-charger driver has this logic inverted. Correct that thus
correcting enable/disable_irq_wake() calls balance.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/power/gpio-charger.c

index a0024b252197d195a8a1170b68d2c28ad8f3696b..86e03c6d28f3cbd76faa4f7df9b415ca7b5aee4e 100644 (file)
@@ -168,7 +168,7 @@ static int gpio_charger_suspend(struct device *dev)
 
        if (device_may_wakeup(dev))
                gpio_charger->wakeup_enabled =
-                       enable_irq_wake(gpio_charger->irq);
+                       !enable_irq_wake(gpio_charger->irq);
 
        return 0;
 }
@@ -178,7 +178,7 @@ static int gpio_charger_resume(struct device *dev)
        struct platform_device *pdev = to_platform_device(dev);
        struct gpio_charger *gpio_charger = platform_get_drvdata(pdev);
 
-       if (gpio_charger->wakeup_enabled)
+       if (device_may_wakeup(dev) && gpio_charger->wakeup_enabled)
                disable_irq_wake(gpio_charger->irq);
        power_supply_changed(&gpio_charger->charger);