]> git.hungrycats.org Git - linux/commitdiff
[PATCH] V4L: wm8775/wm8739: Fix memory leak when unloading module
authorHans Verkuil <hverkuil@xs4all.nl>
Tue, 24 Jul 2007 12:07:43 +0000 (08:07 -0400)
committerWilly Tarreau <w@1wt.eu>
Sat, 25 Aug 2007 15:24:04 +0000 (17:24 +0200)
State struct was never freed.

(cherry picked from commit 1b2232ab879993fcf5b9391c3febf6ab5d78201e)

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/media/video/wm8739.c
drivers/media/video/wm8775.c

index a9b59c35cd67e202799a86b09816adcd6fc49ab6..009941b36dcc726292fa420c6e7209f8c42f0cbd 100644 (file)
@@ -317,12 +317,14 @@ static int wm8739_probe(struct i2c_adapter *adapter)
 
 static int wm8739_detach(struct i2c_client *client)
 {
+       struct wm8739_state *state = i2c_get_clientdata(client);
        int err;
 
        err = i2c_detach_client(client);
        if (err)
                return err;
 
+       kfree(state);
        kfree(client);
        return 0;
 }
index d81a88bbe43d02a8aac3f61a575facb07153615a..e555b3ab09e66372998b4288001a70d12f912da6 100644 (file)
@@ -218,12 +218,14 @@ static int wm8775_probe(struct i2c_adapter *adapter)
 
 static int wm8775_detach(struct i2c_client *client)
 {
+       struct wm8775_state *state = i2c_get_clientdata(client);
        int err;
 
        err = i2c_detach_client(client);
        if (err) {
                return err;
        }
+       kfree(state);
        kfree(client);
 
        return 0;