]> git.hungrycats.org Git - linux/commitdiff
[PATCH] Remove pointless code from ALSA emu10k1 midi driver.
authorDave Jones <davej@redhat.com>
Thu, 2 Sep 2004 07:37:04 +0000 (00:37 -0700)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Thu, 2 Sep 2004 07:37:04 +0000 (00:37 -0700)
Spotted with the source checker from Coverity.com.

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
sound/oss/emu10k1/midi.c

index ec2424db43cb18826a8724151c597be57863f457..f0a48f39f2ed05b6674ae628dfd53ddb027bb22f 100644 (file)
@@ -320,7 +320,6 @@ static ssize_t emu10k1_midi_write(struct file *file, const char __user *buffer,
 {
        struct emu10k1_mididevice *midi_dev = (struct emu10k1_mididevice *) file->private_data;
        struct midi_hdr *midihdr;
-       ssize_t ret = 0;
        unsigned long flags;
 
        DPD(4, "emu10k1_midi_write(), count=%#x\n", (u32) count);
@@ -344,7 +343,7 @@ static ssize_t emu10k1_midi_write(struct file *file, const char __user *buffer,
        if (copy_from_user(midihdr->data, buffer, count)) {
                kfree(midihdr->data);
                kfree(midihdr);
-               return ret ? ret : -EFAULT;
+               return -EFAULT;
        }
 
        spin_lock_irqsave(&midi_spinlock, flags);