]> git.hungrycats.org Git - linux/commitdiff
rtc: ab-eoz9: don't fail temperature reads on undervoltage notification
authorMaxime Chevallier <maxime.chevallier@bootlin.com>
Fri, 22 Nov 2024 10:10:30 +0000 (11:10 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 12:54:31 +0000 (13:54 +0100)
[ Upstream commit e0779a0dcf41a6452ac0a169cd96863feb5787c7 ]

The undervoltage flags reported by the RTC are useful to know if the
time and date are reliable after a reboot. Although the threshold VLOW1
indicates that the thermometer has been shutdown and time compensation
is off, it doesn't mean that the temperature readout is currently
impossible.

As the system is running, the RTC voltage is now fully established and
we can read the temperature.

Fixes: 67075b63cce2 ("rtc: add AB-RTCMC-32.768kHz-EOZ9 RTC support")
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://lore.kernel.org/r/20241122101031.68916-3-maxime.chevallier@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/rtc-ab-eoz9.c

index 02f7d0711287723a480fdf7d079ba2ea5e59ce61..e17bce9a27468b4aa9edc46f14d52912a0b6c1ce 100644 (file)
@@ -396,13 +396,6 @@ static int abeoz9z3_temp_read(struct device *dev,
        if (ret < 0)
                return ret;
 
-       if ((val & ABEOZ9_REG_CTRL_STATUS_V1F) ||
-           (val & ABEOZ9_REG_CTRL_STATUS_V2F)) {
-               dev_err(dev,
-                       "thermometer might be disabled due to low voltage\n");
-               return -EINVAL;
-       }
-
        switch (attr) {
        case hwmon_temp_input:
                ret = regmap_read(regmap, ABEOZ9_REG_REG_TEMP, &val);