hpsa: fix memory leak in kdump hard reset

commit 03741d956eaac31264952e0afa181b62713892a5 upstream.

There is a potential memory leak in hpsa_kdump_hard_reset_controller.

Reviewed-by: Don Brace <don.brace@pmcs.com>
Reviewed-by: Scott Teel <scott.teel@pmcs.com>
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Don Brace <don.brace@pmcs.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Cc: Vinson Lee <vlee@twopensource.com>
Signed-off-by: Zefan Li <lizefan@huawei.com>

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index cdff47e34d2453febf5edd3121b098949e7b6b76..f5ccdcdf2cabb5907e9a4d823d852216698a550d 100644 (file)
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -3530,7 +3530,7 @@ static __devinit int hpsa_kdump_hard_reset_controller(struct pci_dev *pdev)
        }
        rc = write_driver_ver_to_cfgtable(cfgtable);
        if (rc)
-               goto unmap_vaddr;
+               goto unmap_cfgtable;
 
        /* If reset via doorbell register is supported, use that.
         * There are two such methods.  Favor the newest method.