]> git.hungrycats.org Git - linux/commitdiff
drm/xe/hw_error: Defeature hardware error handling with system controller
authorRaag Jadav <raag.jadav@intel.com>
Thu, 18 Jun 2026 15:31:26 +0000 (21:01 +0530)
committerRiana Tauro <riana.tauro@intel.com>
Fri, 19 Jun 2026 05:26:30 +0000 (10:56 +0530)
Hardware errors are reported through System Controller on the platforms
that support it, and never routed as direct IRQ to SGUnit. Defeature
their handling to prevent unexpected side effects.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Reviewed-by: Riana Tauro <riana.tauro@intel.com>
Link: https://patch.msgid.link/20260618153209.110899-2-raag.jadav@intel.com
Signed-off-by: Riana Tauro <riana.tauro@intel.com>
drivers/gpu/drm/xe/xe_hw_error.c

index 4b72959b227610760c3bcbbb8a22b728fbb0d6d2..db228043dbe54c21a6e24c78fc60dab7309cf749 100644 (file)
@@ -437,6 +437,16 @@ static void hw_error_source_handler(struct xe_tile *tile, const enum hardware_er
        if (!IS_DGFX(xe))
                return;
 
+       /*
+        * Hardware errors are reported through System Controller on the platforms that
+        * support it, and never routed as direct IRQ to SGUnit. So we should never be
+        * here for those platforms.
+        */
+       if (xe->info.has_sysctrl) {
+               drm_err_ratelimited(&xe->drm, HW_ERR "Invalid error routing\n");
+               return;
+       }
+
        spin_lock_irqsave(&xe->irq.lock, flags);
        err_src = xe_mmio_read32(&tile->mmio, DEV_ERR_STAT_REG(hw_err));
        if (!err_src) {