From: Zygo Blaxell Date: Mon, 27 Apr 2026 21:30:24 +0000 (-0400) Subject: BeesRangePair: don't slowly compare the extent data when creating a BeesFileRange X-Git-Url: http://git.hungrycats.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=94c13145e2ef85ddc8fcb02f8ec0b766dc2b039d;p=bees BeesRangePair: don't slowly compare the extent data when creating a BeesFileRange This has been duplicating reads for every dedupe since 2016! Signed-off-by: Zygo Blaxell --- diff --git a/src/bees-types.cc b/src/bees-types.cc index 68b6ce49..665f20db 100644 --- a/src/bees-types.cc +++ b/src/bees-types.cc @@ -316,25 +316,6 @@ BeesRangePair::BeesRangePair(const BeesFileRange &src, const BeesFileRange &dst) // Must initially be equal THROW_CHECK2(invalid_argument, first, second, first.size() == second.size()); - - // Can't check content unless open - if (!first.fd() || !second.fd()) { - return; - } - - // Must check every block individually - off_t first_begin = first.begin(); - off_t second_begin = second.begin(); - off_t size = first.size(); - while (size) { - off_t len = min(BLOCK_SIZE_SUMS, size); - BeesBlockData first_bbd(first.fd(), first_begin, len); - BeesBlockData second_bbd(second.fd(), second_begin, len); - THROW_CHECK2(invalid_argument, first_bbd, second_bbd, first_bbd.is_data_equal(second_bbd)); - first_begin += len; - second_begin += len; - size -= len; - } } bool