From: Zygo Blaxell Date: Sun, 19 Jan 2025 06:02:53 +0000 (-0500) Subject: log: demote a lot of BEESLOGWARN to higher verbosity levels X-Git-Url: http://git.hungrycats.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a2b3e1e0c28b707c98080211dee02137c1e60fb5;p=bees log: demote a lot of BEESLOGWARN to higher verbosity levels Toxic extent workarounds are going away because the underlying kernel bugs have been fixed. They are no longer worthy of spamming non-developer logs. INO_PATHS can return no paths if an inode has been deleted. It doesn't need a log message at all, much less one at WARN level. Dedupe failure can be INFO, the same level as dedupe itself, especially since the "NO dedupe" message doesn't mention what was [not] deduped. Inspired by Kai Krakow's "context: demote "abandoned toxic match" to debug log level". Signed-off-by: Zygo Blaxell --- diff --git a/src/bees-context.cc b/src/bees-context.cc index 1f1ed7e9..7602e21f 100644 --- a/src/bees-context.cc +++ b/src/bees-context.cc @@ -259,7 +259,7 @@ BeesContext::dedup(const BeesRangePair &brp_in) BEESCOUNTADD(dedup_bytes, brp.first.size()); } else { BEESCOUNT(dedup_miss); - BEESLOGWARN("NO Dedup! " << brp); + BEESLOGINFO("NO Dedup! " << brp); } lock.reset(); @@ -373,7 +373,7 @@ BeesContext::scan_one_extent(const BeesFileRange &bfr, const Extent &e) Extent::OBSCURED | Extent::PREALLOC )) { BEESCOUNT(scan_interesting); - BEESLOGWARN("Interesting extent flags " << e << " from fd " << name_fd(bfr.fd())); + BEESLOGINFO("Interesting extent flags " << e << " from fd " << name_fd(bfr.fd())); } if (e.flags() & Extent::HOLE) { @@ -556,7 +556,7 @@ BeesContext::scan_one_extent(const BeesFileRange &bfr, const Extent &e) BeesResolver resolved(m_ctx, found_addr); // Toxic extents are really toxic if (resolved.is_toxic()) { - BEESLOGWARN("WORKAROUND: discovered toxic match at found_addr " << found_addr << " matching bbd " << bbd); + BEESLOGDEBUG("WORKAROUND: discovered toxic match at found_addr " << found_addr << " matching bbd " << bbd); BEESCOUNT(scan_toxic_match); // Make sure we never see this hash again. // It has become toxic since it was inserted into the hash table. @@ -917,7 +917,7 @@ BeesContext::scan_forward(const BeesFileRange &bfr_in) // Sanity check if (bfr.begin() >= bfr.file_size()) { - BEESLOGWARN("past EOF: " << bfr); + BEESLOGDEBUG("past EOF: " << bfr); BEESCOUNT(scanf_eof); return false; } diff --git a/src/bees-hash.cc b/src/bees-hash.cc index 91b669d3..ab177377 100644 --- a/src/bees-hash.cc +++ b/src/bees-hash.cc @@ -797,7 +797,7 @@ BeesHashTable::BeesHashTable(shared_ptr ctx, string filename, off_t for (auto fp = madv_flags; fp->value; ++fp) { BEESTOOLONG("madvise(" << fp->name << ")"); if (madvise(m_byte_ptr, m_size, fp->value)) { - BEESLOGWARN("madvise(..., " << fp->name << "): " << strerror(errno) << " (ignored)"); + BEESLOGNOTICE("madvise(..., " << fp->name << "): " << strerror(errno) << " (ignored)"); } } diff --git a/src/bees-roots.cc b/src/bees-roots.cc index 15a6ce8f..0c2dfb0d 100644 --- a/src/bees-roots.cc +++ b/src/bees-roots.cc @@ -1990,7 +1990,7 @@ BeesRoots::open_root_ino_nocache(uint64_t root, uint64_t ino) BEESTRACE("searching paths for root " << root << " ino " << ino); Fd rv; if (ipa.m_paths.empty()) { - BEESLOGWARN("No paths for root " << root << " ino " << ino); + // BEESLOGDEBUG("No paths for root " << root << " ino " << ino); BEESCOUNT(open_lookup_empty); } BEESCOUNT(open_lookup_ok); @@ -2066,7 +2066,7 @@ BeesRoots::open_root_ino_nocache(uint64_t root, uint64_t ino) int attr = ioctl_iflags_get(rv); if (attr & FS_NOCOW_FL) { - BEESLOGWARN("Opening " << name_fd(rv) << " found FS_NOCOW_FL flag in " << to_hex(attr)); + BEESLOGINFO("Opening " << name_fd(rv) << " found FS_NOCOW_FL flag in " << to_hex(attr)); rv = Fd(); BEESCOUNT(open_wrong_flags); break; diff --git a/src/bees-types.cc b/src/bees-types.cc index bd89c4b7..3ee21d38 100644 --- a/src/bees-types.cc +++ b/src/bees-types.cc @@ -457,7 +457,7 @@ BeesRangePair::grow(shared_ptr ctx, bool constrained) } } if (found_toxic) { - BEESLOGWARN("WORKAROUND: found toxic hash in " << first_bbd << " while extending backward:\n" << *this); + BEESLOGDEBUG("WORKAROUND: found toxic hash in " << first_bbd << " while extending backward:\n" << *this); BEESCOUNT(pairbackward_toxic_hash); break; } @@ -558,7 +558,7 @@ BeesRangePair::grow(shared_ptr ctx, bool constrained) } } if (found_toxic) { - BEESLOGWARN("WORKAROUND: found toxic hash in " << first_bbd << " while extending forward:\n" << *this); + BEESLOGDEBUG("WORKAROUND: found toxic hash in " << first_bbd << " while extending forward:\n" << *this); BEESCOUNT(pairforward_toxic_hash); break; } diff --git a/src/bees.cc b/src/bees.cc index ffcd6c87..95e2b47e 100644 --- a/src/bees.cc +++ b/src/bees.cc @@ -198,7 +198,7 @@ BeesTooLong::check() const if (age() > m_limit) { ostringstream oss; m_func(oss); - BEESLOGWARN("PERFORMANCE: " << *this << " sec: " << oss.str()); + BEESLOGINFO("PERFORMANCE: " << *this << " sec: " << oss.str()); } }