From: Zygo Blaxell Date: Mon, 3 Feb 2025 04:30:26 +0000 (-0500) Subject: roots: drop unnecessary mutex unlock in stop_request X-Git-Url: http://git.hungrycats.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c1d7fa13a56003e0a934c9651b30d0be4e70c5e7;p=bees roots: drop unnecessary mutex unlock in stop_request In commit 31b2aa3c0dcf042559fa495b63a1bf22bac4d55d ("context: speed up orderly process termination"), the stop request was split into two methods after the mutex unlock. Now that there's nothing after the mutex unlock in `stop_request`, there's no need for an explicit unlock to do what the destructor would have done anyway. Signed-off-by: Zygo Blaxell --- diff --git a/src/bees-roots.cc b/src/bees-roots.cc index dd675cbf..0d03594c 100644 --- a/src/bees-roots.cc +++ b/src/bees-roots.cc @@ -1938,7 +1938,6 @@ BeesRoots::stop_request() unique_lock lock(m_stop_mutex); m_stop_requested = true; m_stop_condvar.notify_all(); - lock.unlock(); } void