From: Mark Brown Date: Mon, 20 Jun 2016 12:53:34 +0000 (+0100) Subject: iio:ad7266: Fix probe deferral for vref X-Git-Tag: v3.16.37~70 X-Git-Url: http://git.hungrycats.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e5dbfa75116a77d70aaf80e79733c47be4891afc;p=linux iio:ad7266: Fix probe deferral for vref commit 68b356eb3d9f5e38910fb62e22a78e2a18d544ae upstream. Currently the ad7266 driver treats any failure to get vref as though the regulator were not present but this means that if probe deferral is triggered the driver will act as though the regulator were not present. Instead only use the internal reference if we explicitly got -ENODEV which is what is returned for absent regulators. Signed-off-by: Mark Brown Signed-off-by: Jonathan Cameron Signed-off-by: Ben Hutchings --- diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c index 2bd08eea94f1..8e2b9e70511d 100644 --- a/drivers/iio/adc/ad7266.c +++ b/drivers/iio/adc/ad7266.c @@ -408,6 +408,9 @@ static int ad7266_probe(struct spi_device *spi) st->vref_mv = ret / 1000; } else { + /* Any other error indicates that the regulator does exist */ + if (PTR_ERR(st->reg) != -ENODEV) + return PTR_ERR(st->reg); /* Use internal reference */ st->vref_mv = 2500; }