Matthew Wilcox [Wed, 14 Jan 2004 06:47:05 +0000 (01:47 -0500)]
[PATCH] Re: Building sym 2.1.18f on linux/alpha
On Tue, Jan 13, 2004 at 06:02:08PM +0300, Sergey Tikhonov wrote:
> The final kernel could not pass linking stage with 2.1.18f version
> (included into 2.6.1 kernel patch).
> The linker complains that :
> drivers/built-in.o(.init.text+0x8cec): In function 'sym2_probe':
> : undfined reference to 'local symbols in discarded section .exit.text'
>
> I compared arch/alpha/kernel/vmlinux.lds.S with one from the i386 tree.
> The '.exit.text' and '.exit.data'
> sections were moved out of DISCARD attributes in the i386 version. I did
> the same with alpha version
> and it helped.
Thanks for this report; you uncovered a real bug. Actually two real
bugs; one is that parisc is not discarding the .init.text and .exit.text
sections (so I didn't notice this bug) and the other is that sym_detach
is marked __devexit, yet called from a __devinit function.
Adrian Bunk [Sun, 11 Jan 2004 03:48:04 +0000 (22:48 -0500)]
[PATCH] qla1280.c doesn't compile
On Wed, Jan 07, 2004 at 11:28:31PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.1-rc1-mm2:
>...
> -qla1280-update.patch
> +qla1280-update-2.patch
>
> Updated qlogic patch
>...
I got the following compile error when trying to compile this driver
statically into a kernel with hotplug enabled:
<-- snip -->
...
drivers/scsi/qla1280.c:4849: error: `qla1280_remove_one' undeclared here
(not in a function)
drivers/scsi/qla1280.c:4849: error: initializer element is not constant
drivers/scsi/qla1280.c:4849: error: (near initialization for
`qla1280_pci_driver.remove')
make[2]: *** [drivers/scsi/qla1280.o] Error 1
<-- snip -->
Since I don't see a good reason why qla1280_remove_one is #ifdef'ed out
in the non-modular case the patch below fixes this problem by removing
two #ifdef's.
James Bottomley [Sat, 10 Jan 2004 16:14:57 +0000 (11:14 -0500)]
Mac SCSI fixes (from Matthias Urlichs)
From: Geert Uytterhoeven <geert@linux-m68k.org>
Mac SCSI fixes (from Matthias Urlichs):
- Inline functions need to be defined before being used.
- out_8() takes an address and a value, not the other way round.
James Bottomley [Sat, 10 Jan 2004 16:09:04 +0000 (11:09 -0500)]
sym2 speed selection fix
From: Alex Tomas <alex@clusterfs.com>
without following patch I couldn't get 160MB from my disk. removed line
restores previous clocking value (0 in my case). so, driver thinks disk
isn't DT-capable ...
James Bottomley [Sat, 10 Jan 2004 10:37:47 +0000 (05:37 -0500)]
SCSI sg,st block layer TCQ fix
Usually, the mid layer ends the block tag (if one was in use)
early to release the resources. However, things like sg and st
don't go through the code path that does the release, so put a
fallback release in __scsi_release_request() for them.
On Tue, Jan 06, 2004 at 07:33:25PM +0100, Adrian Bunk wrote:
> On Wed, Dec 31, 2003 at 12:36:49AM -0800, Linus Torvalds wrote:
> >...
> > Summary of changes from v2.6.0 to v2.6.1-rc1
> > ============================================
> >...
> > Patrick Mansfield:
> > o consolidate and log scsi command on send and completion
> >...
>
> This adds a #define TIMEOUT to scsi.h conflicting with a different
> TIMEOUT #define in drivers/scsi/eata_generic.h:
Sorry Adrian, here is a patch renaming TIMEOUT to TIMEOUT_ERROR. Still
not a good name for the usage in SCSI core, but it does not conflict, and
matches the other names for the IO completion results (SUCCESS, FAILED,
etc., they and others should really be prefixed with at least SCSI).
eata does not use the TIMEOUT it defines, but there are enough defines of
TIMEOUT that it could be a problem in other drivers.
Jes Sorensen [Sat, 10 Jan 2004 06:47:47 +0000 (01:47 -0500)]
[PATCH] qla1280
I am attaching the latest version of the qla1280 driver for inclusion in
the next 2.6.x release. It is mostly based on Christoph's cleanup work
and a couple of changes of my own. I don't know if it is too late for
2.6.1, but otherwise it would be nice to get it into 2.6.2.
I have built and tested this using 2.6.0-test11 on an ia64, but I don't
think there were any major SCSI changes since then.
Linus Torvalds [Thu, 8 Jan 2004 03:46:52 +0000 (19:46 -0800)]
Fix subtle fork() race that Ingo noticed.
We must not mark the process TASK_STOPPED early, because
that might allow a signal to wake it up before we actually
got to the "wake_up_forked_process()" state. Total confusion
would happen.
Make wake_up_forked_process() verify the new world order.
Dave Jones [Wed, 7 Jan 2004 14:53:58 +0000 (14:53 +0000)]
[AGPGART] Add support for Radeon IGP345M to ATI GART driver.
Also consolidate a bunch of convoluted if's into a single
"is this an r200 or r300" function.
Andrew Morton [Wed, 7 Jan 2004 13:56:59 +0000 (05:56 -0800)]
[PATCH] ppc64: Add missing section definition
From: Anton Blanchard <anton@samba.org>
For a laugh we moved the BSS and our world exploded. Turns out we zero
from __bss_start to _end. Add __bss_stop to our section definitions so
we can use it instead.
Dave Kleikamp [Wed, 7 Jan 2004 02:35:15 +0000 (18:35 -0800)]
[PATCH] don't clear i_sb
From: Christoph Hellwig <hch@lst.de>
JFS currently clears i_sb in some error pathes which can make the
core kernel OOPS because it may never be NULL. Noticed because some
IBM people try to "fix" the core kernel for it now..
Andrew Morton [Tue, 6 Jan 2004 23:52:48 +0000 (15:52 -0800)]
[PATCH] ia32 sched_clock() deadlock fix
From: Ingo Molnar <mingo@elte.hu>,
Voyager is getting odd deadlocks due to the taking of xtime_lock() in
sched_clock()->get_jiffies_64().
I had this patch queued up to fix a different deadlock, which occurs when we
relax the requirement that TSC's be synchronised across CPUs. But it will
fix James' deadlock too.
Andrew Morton [Tue, 6 Jan 2004 23:52:30 +0000 (15:52 -0800)]
[PATCH] JFS fix for NFS on little-endian systems
From: Dave Kleikamp <shaggy@austin.ibm.com>
After Jose debugged the problem down to the routine jfs_get_parent, we
were able to find the problem. I believe it only affects users of
NFS-exported JFS file systems on big-endian hardware.
The problem was a missing le32_to_cpu macro. The patch also fixes a
return code to be more consistent other implementations of get_parent.
Andrew Morton [Tue, 6 Jan 2004 23:52:21 +0000 (15:52 -0800)]
[PATCH] fix sysfs oops
From: Greg KH <greg@kroah.com>
This fixes an oops when a kobject is unregistered before it's child is.
The usb-serial devices show this bug very easily (yank out a device
while its port is opened...)
Patch was originally written by Mike Gorse <mgorse@mgorse.dhs.org>
Andrew Morton [Tue, 6 Jan 2004 23:52:12 +0000 (15:52 -0800)]
[PATCH] MSI build fixes
Add missing NR_VECTORS definition to visws and pc9800. Also, make MSI
support dependent on CONFIG_X86_IO_APIC, as it won't build without IOAPIC
support.
Adam Belay [Tue, 6 Jan 2004 12:08:21 +0000 (04:08 -0800)]
[PATCH] Fix PnP BIOS call
The recent escd fix I have made corrects a thinko in the PnPBIOS code and it
turns out that faults from calling /proc/pnp/bus/escd were probably not caused
by BIOS bugs.
James Bottomley [Mon, 5 Jan 2004 16:12:21 +0000 (10:12 -0600)]
64 bit updates for Workbit NinjaSCSI driver
From: GOTO Masanori <gotom@debian.or.jp>
Thanks for your report. I compiled and exactly I saw some warnings on
amd64 machine. I checked all warnings, and these warnings are
trivial, they can be easily fixed. I attached the patch to fix
warnings. Nsp32 is PCI device driver, so it should also work on amd64
architecture.
Fix for oops on rmmod caused by *_remove() function marked as __devinit
(and thus discarded after module initialization - if CONFIG_MODULES=y
and CONFIG_HOTPLUG is not set).
This patch changes __devinit to __devexit and adds __devexit_p() where
pointer to such function is used.
The only exception is au1000, where au1000_remove() is called from
cleanup_au1000() function - __devinit is jest removed there.