Randy Dunlap [Fri, 3 Oct 2003 15:31:55 +0000 (08:31 -0700)]
[PATCH] janitor: opl3sa2 cleanups/checker
From: Daniele <bellucda@tiscali.it>
- remove unneeded block of code in opl3sa3_mixer_ioctl
- remove unused function opl3sa3_set_wide
- From Stanford Checker:
/home/junfeng/linux-tainted/sound/oss/opl3sa2.c:539:opl3sa3_mixer_ioctl:
ERROR:TAINTED:53 9:539: dereferencing tainted ptr 'arg'
..fixed user space pointer referce too on ioctl functions
Changes include:
Add support for new USA19H(s) USB Serial Adapter
Improve handing of config/control messages for all devices
Note that the new adapter doesn't currently require a firmware download.
We will add support for re-programming the eeprom with updated firmware
when new firmware is required.
Luiz Capitulino [Fri, 3 Oct 2003 08:18:06 +0000 (01:18 -0700)]
[PATCH] USB: fix drivers/usb/host/uhci-debug.c warning when !CONFIG_PROC_FS.
I'm getting this when compiling USB with all options enabled:
drivers/usb/host/uhci-debug.c:417: warning: `uhci_sprint_schedule' defined but not used
my suggestion is to put under the #ifdef/#endif the functions which are
only used by the proc ones too. If one of them become necessary when
CONFIG_PROC_FS=n, the #ifdef/#endif for that function can be removed:
ide_pci_setup_ports() from setup-pci.c checks if port is disabled, if so
d->init_setup_dma() and d->init_hwif() won't be called. There is no need
to check it once again inside init_hwif_amd74xx(), init_dma_amd74xx()
and amd74xx_tune_drive() (hwif->tuneproc will be NULL for disabled port).
Therefore remove amd_enabled variable and now unnecessary init_dma_amd74xx().
Also do not set .init_{iops, dma} to NULL in amd74xx.h (amd74xx_chipsets[]
is declared static). Bump driver's version number to reflect changes.
ide_pci_setup_ports() from setup-pci.c checks if port is disabled, if so
d->init_setup_dma() and d->init_hwif() won't be called. There is no
need to check it once again inside init_hwif_via82cxxx(),
init_dma_via82cxxx() and via82cxxx_tune_drive() (hwif->tuneproc will be
NULL for disabled port).
Therefore remove via_enabled variable and now unnecessary
init_dma_via82cxx(). Also do not set .init_{iops, dma} to NULL in
via82cxxx.h (via82cxxx_chipsets[] is declared static). Bump driver's
version number to reflect changes.
Roland McGrath [Fri, 3 Oct 2003 07:17:11 +0000 (00:17 -0700)]
[PATCH] fix vsyscall page in core dumps
My change to core dumps that was included with the vsyscall DSO
implementation had a bug (braino on my part). Core dumps don't include the
full page of the vsyscall DSO, and so don't accurately represent the whole
memory image of the process. This patch fixes it. I have tested it on
x86, but not tested the same change to 32-bit core dumps on AMD64 (haven't
even compiled on AMD64).
I've also included the corresponding change for the IA64 code that was
copied blindly from the x86 vsyscall implementation, which looks like more
change than it is since I preserved the formatting of the copied code
instead of arbitrarily diddling it along with the trivial symbol name
changes. I haven't compiled or tested on ia64.
Sam Ravnborg [Thu, 2 Oct 2003 23:10:54 +0000 (01:10 +0200)]
kbuild: fixes for separate output directory
- Error out if specified directory does not exist
- Do not build the kernel three times wheh specifying "defconfig all"
- Removed warning when the target all was specified
Rusty Russell [Thu, 2 Oct 2003 16:27:04 +0000 (09:27 -0700)]
[NETFILTER]: LOCAL_OUT NAT fix, part 2.
Balazs Scheidler pointed out that we can fail to call ip_nat_setup_info
for local NAT, which causes the connection to be added twice. Boom.
Also move the hash table insertion into ip_nat_setup_info.
[NETFILTER]: Make conntrack timeouts become sysctls.
This patch introduces the /proc/sys/net/ipv4/netfilter/ directory for=20
the tuneable parameters of the conntrack engine of netfilter.
The parameters which can currently be fine-tuned (if required at all)=20
are the ip_conntrack_max, and the conntrack timeout parameters in seconds.
The default timeout value for the TCP CLOSE_WAIT state is raised to 3
days, which should cause less problems with long-lived half-closed TCP
sessions.
For the sake of compatibility with 2.4,=20
/proc/sys/net/ipv4/netfilter/ip_conntrack_max is duplicated as=20
/proc/sys/net/ipv4/ip_conntrack_max as well.
Harald Welte [Thu, 2 Oct 2003 16:16:59 +0000 (09:16 -0700)]
[NETFILTER]: LOCAL_OUT NAT fix.
the 25_natcore-nohelper.patch (incorporated in 2.4.22) did actually make
things not better. If a NAT rule was matched, num_manips can still be 0.
However, some helpers (like PPTP) need to _always mangle the packets,
even if there is no NAT mapping for a particular connection.
On the other hand, as soon as CONFIG_IP_NF_LOCAL_NAT was disabled,
we did end up half-mangling local (non-NAT'ed) connections. This patch
removes the LOCAL_OUT hook from the NAT core unless CONFIG_IP_NF_NAT_LOCAL
is enabled.
Nick Piggin [Thu, 2 Oct 2003 00:53:23 +0000 (17:53 -0700)]
[PATCH] remove io context refcounting debug
This removes the remains of some debugging stuff which was never really
enabled properly - it never reported memory leaks. Its not useful for
anyone but me.
A proper solution involves counting all requests in flight and all
threads but we'll probably put that just into mm.
Alexander Viro [Thu, 2 Oct 2003 00:38:22 +0000 (17:38 -0700)]
[PATCH] Improve sget() performance
sget() is pessimistic and assumes it won't find a superblock - and as a
result it always pre-allocates a new one before even searching for an
existing entry. If it finds an existing one, it free's the extra one it
just allocated.
Especially with /proc usage it usually _does_ find an existing
superblock, so this is all extra work. It should allocate a new one
only if it couldn't find an old one (and re-search).
Alexander Viro [Wed, 1 Oct 2003 18:11:57 +0000 (11:11 -0700)]
[PATCH] Better UDF oops fix
Rather than not kfree'ing the UDF data in the case of a bad inode (which
still _may_ have had the UDF data already allocated to it), make sure to
initialize the pointer to NULL properly when we're done with it.
here's a new patch that attempts to disable BLK_DEV_FD on platforms which
don't support it. The patch also attempts to remove the duplication of the
logic in compat_ioctl.h.
Andrew Morton [Wed, 1 Oct 2003 17:59:18 +0000 (10:59 -0700)]
[PATCH] /proc/PID/auxv file and NT_AUXV core note
From: Roland McGrath <roland@redhat.com>
gdb really needs some way to know the AT_SYSINFO_EHDR value for a process
being debugged or for the dead process described by a core file. Without
this value, it can't find the information necessary to show backtraces of
threads waiting in system calls. There are any number of ways this
information could be made available. Here is one solution that provides
more debugging information in a clean and general fashion.
I've added access to the AT_* values passed to a process for third parties
to examine for debugging purposes. The same data passed on the stack at
startup is made available in /proc/PID/auxv and is written in an NT_AUXV
note in core dumps. (Both of these are consistent with what Solaris does
using the same names.)
Here are two different patches that implement the same thing differently.
The first patch uses a ref-counted data structure to copy the aux vector
and shares among forked mm's until they exec and get a new one. The second
patch avoids the complexity of that data structure by simply expanding the
mm_struct with space to hold a copy of the data. Both patches work
correctly; I have examined the new /proc/PID/auxv file and core dumps.
I hope you will consider including one of these patches, or at least some
way of getting at this information from the debugger. I am certainly open
to other suggestions on implementing this feature, and to suggestions on
alternative interfaces for getting the AT_SYSINFO_EHDR value cleanly.
Andrew Morton [Wed, 1 Oct 2003 17:58:55 +0000 (10:58 -0700)]
[PATCH] scripts/pnmtologo.c warning fixes
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
this patch makes some ints to unsigned ints. They are only used as loop
counters and compared to unsigned ints. GCC 3.3 doesn't like this. They
will never be negative anyway, so we could easily shut him up.
Andrew Morton [Wed, 1 Oct 2003 17:58:48 +0000 (10:58 -0700)]
[PATCH] Pass nameidata to security_inode_permission hook
From: Stephen Smalley <sds@epoch.ncsc.mil>
This patch changes the security_inode_permission hook to also take a
nameidata parameter in addition to the existing inode and mask parameters.
A nameidata is already passed (although sometimes NULL) to
fs/namei.c:permission(), and the patch changes exec_permission_lite() to
also take a nameidata parameter so that it can pass it along to the
security hook.
The patch includes corresponding changes to the SELinux module to use the
nameidata information when it is available; this allows SELinux to include
pathname information in audit messages when a nameidata structure was
supplied.
Andrew Morton [Wed, 1 Oct 2003 17:58:39 +0000 (10:58 -0700)]
[PATCH] Fix bug in SELinux convert_context
From: Stephen Smalley <sds@epoch.ncsc.mil>
This patch fixes a bug introduced by earlier code cleanups in the SELinux
convert_context code that manifests upon a policy reload that removes
previously valid security attributes. Thanks to Magosanyi Arpad for
reporting the bug.
Andrew Morton [Wed, 1 Oct 2003 17:58:24 +0000 (10:58 -0700)]
[PATCH] check permission in ->open for /proc/sys/
From: Christoph Hellwig <hch@lst.de>
It's the only abuse of proc_iops left (except the totally b0rked comx
driver). The patch is from Al, I just forward-ported it from 2.4.
Background: struct proc_dir_entry has a struct inode_operations *proc_iops
member, it's from Linux's stoneage and used internally by procfs to assign
either the link or directory inode ops.
Unfortunately some drivers started to abuse it do do bad things like create
on lookup (that's the comx thingy which relies on unexported symbols and thus
is broken for modular builds since mid-2.3) or various ->permission tricks
(all gone by now).
After this patch is gone I have another one that kills proc_iops and just
uses a normal conditional inside procfs to assign the right one directly.
Andrew Morton [Wed, 1 Oct 2003 17:58:08 +0000 (10:58 -0700)]
[PATCH] table-driven filesystems option parsing
From: "Randy.Dunlap" <rddunlap@osdl.org>, Will Dyson <will_dyson@pobox.com>, me
Add generic filesystem options parser (infrastructure) and use it to parse
mount options in several filesystems (adfs, affs, autofs, autofs4, ext2,
ext3, fat, hfs, hpfs, isofs, jfs, procfs, udf, and ufs).
It saves between 128 and 512 bytes per filesystem.
Andrew Morton [Wed, 1 Oct 2003 17:57:58 +0000 (10:57 -0700)]
[PATCH] memory writeback/invalidation fixes
From: "David S. Miller" <davem@redhat.com>
This attempts to take care of 2 of the MM todos I had on
my backlog:
1) Zap the stupid flush_cache_all() thing with more meaningful
interfaces.
2) Resolve the ptrace user page access issues, first stage.
The "first stage" mentioned for #2 is simply creating the
user page accesor interfaces. The next stage needs to be
mucking with get_user_pages() so that we can control when
the flush_dcache_page() occurs. Then we:
1) For every platform where flush_dcache_page() is a non-nop
add a call to the beginning of copy_{from,to}_user_page().
2) Make access_process_vm() set the "no dcache flush" bit in
it's call to get_user_pages().
The idea also was that we'd consolidate the write etc. boolean
args passed to get_user_pages() into flag bits too.
But at least with the below, we can delete that reminder FIXME
comment from kernel/ptrace.c, the platforms have the necessary
tools and just need to make use of it :)
As a bonus I noticed that VMALLOC_VMADDR() did absolutely nothing.
After all of this I only have 1 real TODO left, and that's dealing
with the SMP TLB/pte invalidation stuff, very low priority until
someone starts doing more work with sparc32/SMP in 2.6.x :)
Andrew Morton [Wed, 1 Oct 2003 17:57:40 +0000 (10:57 -0700)]
[PATCH] dev_t forward compatibility fix
From: Andries.Brouwer@cwi.nl
ext2 used a 32-bit field for dev_t, with possibly undefined storage
following; thus, no action was required to go to 32-bit dev_t, but going to
64-bit dev_t required some subtlety: 0 was written in the first word and
the 64 bits in the following two. Al truncated my 64-bit stuff to 32 bits
but did not understand why there was this split, and wrote 0 followed by a
single word. We should at least zero the word following to have
well-defined storage later.
Sadly, after wandering aimlessly in the desert of unloved patches all
those years, all attribution got lost. This adds a copyright + license
to scripts/bin2c.c, which hasn't aged a day.
Andrew Morton [Wed, 1 Oct 2003 17:57:16 +0000 (10:57 -0700)]
[PATCH] Fix double request_region in com20020
From: Herbert Xu <herbert@gondor.apana.org.au>
Currently com20020 and com20020_cs both call request_region on the same
block of ports leading to a conflict. This patch resolves this by moving
request_region out of the generic driver and into the isa/pci/cs drivers.
The hugetlbfs_fill_super() doesn't free up memory allocated for sbinfo on
the way out in case of parsing error (and a few others). This leads to
memory leak If root tries to mount a hugetlbfs with invalid mount option.
Here is a patch that fix the problem.
Jes Sorensen [Wed, 1 Oct 2003 15:56:56 +0000 (08:56 -0700)]
[PATCH] qla1280 locking update
This fixes the qla1280 driver to not try to release an unlocked spinlock
at boot time - as well as a couple of other minor mods.
I also changed the MMIO option to be dependant on X86_VISWS as it's
really a chipset problem and not something each and every driver should
be asking for.
Getting a global CONFIG_MMIO_IS_BROKEN option would probable be a win
here.
Ivan Kokshaysky [Wed, 1 Oct 2003 15:52:33 +0000 (08:52 -0700)]
[PATCH] Alpha cypress CPU frequency calibration
This fixes (again...) CPU frequency calibration on some platforms with
the Cypress chip. That is, at some point CLOCK_TICK_RATE has been
changed to represent RTC reference clock instead of PIC one. Which
makes calibrate_cc_with_pic() produce utterly bogus results.
o kernel/ksyms.c: set_cpus_schedule was EXPORT_SYMBOL_GPL, bring it back
Originally, before this set of patches moving stuff out from kernel/ksyms.c,
set_cpus_schedule was EXPORT_SYMBOL_GPL, my mistake, bring it back.
Also follow Andrew Morton's suggestions of moving the EXPORT_SYMBOL{_GPL) even
closer to the place where the symbol exported is defined, i.e. just after the
symbol definition, this makes mistakes more difficult to happen, as when the
symbol definition is #ifdefed the EXPORT_SYMBOL{_GPL} is in the same block.
projects / linux / log