Andrew Morton [Tue, 20 Jan 2004 11:13:29 +0000 (03:13 -0800)]
[PATCH] Default hooks protecting the XATTR_SECURITY_PREFIX namespace
From: Chris Wright <chrisw@osdl.org>
Add default hooks for both the dummy and capability code to protect the
XATTR_SECURITY_PREFIX namespace. These EAs were fully accessible to
unauthorized users, so a user that rebooted from an SELinux kernel to a
default kernel would leave those critical EAs unprotected.
Andrew Morton [Tue, 20 Jan 2004 11:12:44 +0000 (03:12 -0800)]
[PATCH] md: Small fixes for timely writing of md superblocks.
From: NeilBrown <neilb@cse.unsw.edu.au>
Currently a raid0 superblock is only written when the array is stopped, so a
crash between creation and stop can lose your data.
This patch marks a superblock 'dirty' at creation and forces a dirty
superblock to be written when the array is started.
Previously we would prod the per-array thread at this point, but as it avoids
certain chores when the array is locked, and the array is locked at this
point, that isn't guaranteed to do the right thing. Instead we prod the
thread whenever the array is unlocked.
Finally, only write the superblock at array stop if it is needed to mark the
array as 'clean'. raid0 which is never dirty, doesn't need this.
Andrew Morton [Tue, 20 Jan 2004 11:12:27 +0000 (03:12 -0800)]
[PATCH] md: Make sure md recovery happens appropriately.
From: NeilBrown <neilb@cse.unsw.edu.au>
Currently if there are two failed drives, and two spares are added, then
recovery starts onto the first spare, but never notices the second spare. To
cope, we set RECOVERY_NEEDED when recovery finishes so that we re-check.
Andrew Morton [Tue, 20 Jan 2004 11:12:09 +0000 (03:12 -0800)]
[PATCH] md: Make sure an interrupted resync doesn't seem to have completed.
From: NeilBrown <neilb@cse.unsw.edu.au>
If the raid1 or raid5 thread gets to run md_check_recovery after the recovery
thread has been interupted, but before do_md_stop completes, a spare drive
can be incorporated into an array befure it is up-to-date.
raid5 rebuild takes stripes so agressively that other access cannot get a
look-in.
With this patch, the rebuild pauses slightly if there is a shortage of
stripes to let other processes have a chance.
akpm: I was worried about starvation due to the harsh semantics of yield() in
2.6. But Neil has performed specific testing for that and things seem OK.
If people do note CPU starvation problems we will need to replace the yield()
with a schedule_timeout(1).
Andrew Morton [Tue, 20 Jan 2004 11:11:51 +0000 (03:11 -0800)]
[PATCH] md: fix return code in set_disk_faulty()
From: NeilBrown <neilb@cse.unsw.edu.au>
Following are 10 patches for md in 2.6.1-lastest.
1-6 are simple bugfixes that I am confident should be in 2.6.2.
7 is a bugfix that is fairly important, but could probably do with a
bit more testing first. It is not impossible that it could deadlock,
though I think I have caught and fixed all the problems.
8-10 are code simplication.
So maybe 7-10 should only go in -mm for now, but if it is a while
before 2.6.2, then maybe they can go in a 2.6.2-pre.
From: Mike Tran <mhtran@us.ibm.com>
If cannot find the device, return error (ENODEV) Otherwise, return success
(0)
Andrew Morton [Tue, 20 Jan 2004 11:11:42 +0000 (03:11 -0800)]
[PATCH] check for truncated modules
From: Rusty Russell <rusty@rustcorp.com.au>
I *do* want to add a check for a truncated module, since that's probably
the most common case (^C on "make modules_install"). But I don't want to
double the size of module.c with every check I can think of.
Andrew Morton [Tue, 20 Jan 2004 11:11:23 +0000 (03:11 -0800)]
[PATCH] One-shot support for epoll
From: Davide Libenzi <davidel@xmailserver.org>
The attached patch implements the one-shot support for epoll. Because of
the way epoll works (hooking f_op->poll()) the ET behavior is not really ET
because it might happen that, while data is still available to read (for
the EPOLLIN case), another chunk will become available triggering another
event.
While those conditions can be easily be handled in userspace, the absolute
triviality of the patch and the avoidance of user/kernel space switches and
f_op->poll() calls, make IMHO worth doing this inside epoll itself.
Andrew Morton [Tue, 20 Jan 2004 11:10:48 +0000 (03:10 -0800)]
[PATCH] ppc64: iSeries virtual console
From: Stephen Rothwell <sfr@canb.auug.org.au>
This is a forward port of a 2.4 driver that has been present in a couple of
(enterprise) distributions for some time. It works for me :-), I even get
console output :-) This makes the machine almost usable - next we will get
virtual disk.
It has been considerably tidied up, but if you have any further worries
with it, let me know.
Andrew Morton [Tue, 20 Jan 2004 11:10:38 +0000 (03:10 -0800)]
[PATCH] ppc64: Bug fix for hugepages on ppc64
From: David Gibson <david@gibson.dropbear.id.au>
Currently the flag indicating whether or not hugepages are allowed below
4GB is not correctly propagated across fork(), which can lead to oopses.
The patch below fixes this.
Andrew Morton [Tue, 20 Jan 2004 11:10:20 +0000 (03:10 -0800)]
[PATCH] Fix for 32-bit execve() error path
From: David Gibson <david@gibson.dropbear.id.au>
The patch below fixes a bug in ppc64's 32-bit execve() path. It duplicates
logic already in the normal fs/exec.c do_execve() to avoid dropping a NULL
mm. The bprm.mm becomes NULL once the exec passes the "point of no
return". Without this patch a failure past that point (e.g. mmap()
failure) will cause an oops, with it just a killed process.
Pete Zaitcev [Tue, 20 Jan 2004 08:53:52 +0000 (00:53 -0800)]
[PATCH] USB: Band-aid for mct_u232 in 2.6.1
On Sun, 18 Jan 2004 00:37:44 -0800
Pete Zaitcev <zaitcev@redhat.com> wrote:
> My Magic Control Technology adapter causes an oops in the following way.
> Connect the thing, run "cat < /dev/ttyUSB0", disconnect, kill cat with ^C.
> The result looks like this:
I played with it a little more, and pretty much got everything working,
thus fixing two Fedora bugs.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=112889
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=113700
Matthew Dharm [Tue, 20 Jan 2004 08:03:17 +0000 (00:03 -0800)]
[PATCH] USB Storage: Sysfs attribute file for max_sectors
After much discussion with the SCSI folks, here's a patch to export
max_sectors as a sysfs attribute. Turning this down makes some people's
devices more stable, but at a significant cost in performance. Now, users
can adjust it without recompilation.
Alan Stern [Tue, 20 Jan 2004 08:02:47 +0000 (00:02 -0800)]
[PATCH] USB Storage: Notify the SCSI layer about device resets
According to James Bottomley, we need to notify the SCSI midlayer whenever
we issue a driver-initiated device reset. That can happen in several
places, most notably following a transport error. This patch adds
code to the reset routine to take care of it. (Notifying about resets
requested by the midlayer itself is unnecessary but harmless.)
Alan Stern
On 15 Dec 2003, James Bottomley wrote:
> It looks like the driver sent a reset to the device on its own without
> reporting it to the mid-layer.
>
> There's an expecting_cc_ua flag in the scsi_device. It gets set on
> error recovery actions, or if the device does something to detect or
> trigger a reset (that's the scsi_report_device_reset() and
> scsi_report_bus_reset() API's).
>
> James
Adam Kropelin [Tue, 20 Jan 2004 08:02:17 +0000 (00:02 -0800)]
[PATCH] USB: hiddev HIDIOCGREPORT not blocking in 2.6
I've noticed in 2.6 kernels that HIDIOCGREPORT does not wait for io
completion before returning to the caller. This creates a few unpleasant
issues for userspace:
...that used to work in 2.4 now fail in 2.6 if the device takes more
than a few milliseconds to respond to HIDIOCGREPORT. (I'm seeing this
issue on APC UPSes, FWIW.)
Second, userspace code can easily flood the kernel with control messages
since the kernel provides no "backpressure". The result is a lot of
"hid-core.c: control queue full" errors and lost reports.
2.6 hid-core.c appears to submit the request and return immediately.
Although the 2.4 code differs significantly, I traced the call path to
usb-core.c, which seems to block with a timeout, so the code supports my
userspace observation. (Assuming I didn't misread it.)
Frank Becker [Tue, 20 Jan 2004 22:26:42 +0000 (22:26 +0000)]
[ARM PATCH] 1703/1: SA Cerf update (cleanup)
Patch from Frank Becker
Crud removal. Updated cerf doc.
The SA CerfPDA/CerfPOD have long been gone. I see no
community activity. The last official release was 2.4.9.
Removed ifdefs for CERF_CPLD (which referred to the PDA/POD), go figure.
Removed keyboard driver.
Removed default configs for PDA/POD.
Removed PDA/POD related LCD stuff.
NEC ARM710T is used in Psion Windermere architecture, and possibly
other systems.
710T works fine with the 720T functions, except the high_mapping
does not work for vectors_base(). Even if the high bit register is
set, the vectors stay at 0x00000000 instead of 0xffff0000.
This declares the pxa2xx_udc platform device, defines
the platform_data made available to that driver, and
allows different machines to customize that platform_data.
Same idea as in the FB driver. Be careful of patch conflicts
applying to other kernels, mostly due to different platform
devices being listed.
Alan Stern [Tue, 20 Jan 2004 06:50:56 +0000 (22:50 -0800)]
[PATCH] USB UHCI: fix broken data toggles for queued control URBs
This patch fixes a long-standing (albeit unidentified) problem in the
queueing code for the UHCI HCD. The code propagates data toggle settings
between messages in a queue for control transfers just the same as bulk
and interrupt transfers. That is a mistake, since control messages always
restart with data toggle 0. With this patch, the UHCI driver now passes
test 10 (control URB queueing) in David Brownell's usbtest suite.
The patch appears to change more than it really does, because it alters
the indentation level of a large section of code.
Paul Mackerras [Mon, 19 Jan 2004 13:49:29 +0000 (05:49 -0800)]
[PATCH] sort exception tables
This patch arranges for the exception tables to be sorted on most
architectures. It sorts the main kernel exception table on startup
and the module exception tables when they get loaded. The main table
is sorted reasonably early - just after kmem_cache_init - but that
could be moved even earlier if necessary.
There is now a lib/extable.c which includes the sort_extable()
function from arch/ppc/mm/extable.c and the search_extable() function
from arch/i386/mm/extable.c, which had been copied to many
architectures. On many architectures, arch/$(ARCH)/mm/extable.c
became empty and so I have removed it.
There are four architectures which do things differently from i386:
alpha, ia64, sparc and sparc64. Alpha and ia64 store the offset from
the offset from the exception table entry to the instruction, and
sparc and sparc64 have range entries in the table. For those
architectures I have added empty sort_extable functions. The
maintainers for those architectures can implement something better if
they care to. As it is they are no worse off than before.
Although it is a moderately sizable patch, it ends up with a net
reduction of 377 lines in the size of the kernel source. :)
I have tested this on x86 and ppc with a module that uses __get_user
in an init function, deliberately laid out to get the exception table
out of order, and it works (whereas it oopsed without this patch).
Sanitize 66MHz clock use: "enable" 66MHz clock before starting UDMA3/4/5
read/write transfer and "disable" it after finishing transfer.
- fixes timings for non-UDMA3/4/5 operations (correct 33MHz timings are used)
- allows using UDMA3/4/5 modes on a capable drive even if non-UDMA3/4/5 drive
is present on the same channel
- fixes corner case when one drive on the channel was using UDMA66/100 + LBA48
(so clock was enabled/disabled for each read/write) and other one was using
UDMA66/100 + LBA28, it could happen that request on LBA48 drive disabled
66MHz clock and it was not enabled for the next transfer on LBA28 drive
Ville Nuorvala [Mon, 19 Jan 2004 13:37:58 +0000 (05:37 -0800)]
[IPV6]: Stricter checks on link-locals in bind and sendmsg
When binding to a link-local address, inet6_bind() and raw6_bind() only
check that an interface is specified and that the address exists, but
they don't check if it actually exists on the specified interface.
Similarly, in datagram_sent_ctl() we don't check for the possibility of a
link-local address when we receive the source address from userspace.
Andrew Morton [Mon, 19 Jan 2004 13:16:24 +0000 (05:16 -0800)]
[PATCH] reiserfs v3 should throttle writers
From: Chris Mason <mason@suse.com>
The v3 reiserfs_file_write func doesn't do any write throttling, which
leads to a variety of problems. Here's a patch that makes
reiserfs_file_write call balance_dirty_pages_ratelimited, and exports that
func for module usage.
Andrew Morton [Mon, 19 Jan 2004 13:15:31 +0000 (05:15 -0800)]
[PATCH] ALI M1533 audio hang fix
From: risto.sandvik@helsinki.fi
Everything freezes when trying to play sounds using the alsa driver opl3sa2
(kernel supplied or 1.0.0rc2) on an Acer Extensa series laptop with the Ali
M1533 PCI to ISA bridge. Problem exists both in the 2.6 and 2.4 series of
kernels.
Adding AL_M1533 to drivers/pci/quirks.c fixes the problem for both. This has
been a known problem since 2.2.x (see
http://www.mfn.unipmn.it/~sitta/linux503.html)
Andrew Morton [Mon, 19 Jan 2004 13:15:03 +0000 (05:15 -0800)]
[PATCH] sgiioc4.c cleanup weak symbol and error numbers
From: Jes Sorensen <jes@trained-monkey.org>
The included patch removes the usage of weak symbols from sgiioc4.c now
that we have the Kconfig issue sorted as well as cleans up the error no
handling (instead of return 1 on error) and adds a check for the return
value on snia_pci_endian_set as suggested by Christoph.
Andrew Morton [Mon, 19 Jan 2004 13:14:46 +0000 (05:14 -0800)]
[PATCH] rq_for_each_bio fix
From: Xavier Bestel <xavier.bestel@free.fr>
Within the body of this macro we are accessing rq->bio, but `bio' is an arg
to the macro. If someone uses this macro with some variable which is not
named `bio' it won't compile.
So use a more-likely-to-be-unique identifier for the macro.
Andrew Morton [Mon, 19 Jan 2004 13:14:28 +0000 (05:14 -0800)]
[PATCH] ppc cond_syscall fix
From: Matt Mackall <mpm@selenic.com>
Experimenting with trying to use cond_syscall for a few arch-specific
syscalls, I discovered that it can't actually be used outside the file
in which sys_ni_syscall is declared because the assembler doesn't feel
obliged to output the symbol in that case:
One arch (PPC) is apparently trying to use cond_syscall this way
anyway, though it's probably never been actually tested as the above
test was done on a PPC.
After trying a bunch of tricks to get it to work nicely, I decided
there are basically two alternatives: make weak versions of
sys_ni_syscall wherever they're wanted or put the arch-specific
cond_syscalls in kernel/sys.c where sys_ni_syscall is defined.
The former approach is a bit crufty and doesn't actually do the right
thing in practice as you'll get multiple copies of sys_ni_syscall in
your final image.
The latter introduces some slight arch-pollution in sys.c, but as
arch-specific cond_syscalls aren't all that frequent, it should be
pretty minor. So here's a patch to move the current offender to sys.c:
Andrew Morton [Mon, 19 Jan 2004 13:14:10 +0000 (05:14 -0800)]
[PATCH] fix error case in binfmt_elf.c:load_elf_interp
From: Roland McGrath <roland@redhat.com>
Julie DeWandel noticed that in the error case where elf_map has failed,
load_elf_interp will (at the out_close: label) return the `error' variable,
but that will contain the result of a prior operation and not the error
number from elf_map.
Andrew Morton [Mon, 19 Jan 2004 13:13:14 +0000 (05:13 -0800)]
[PATCH] Arrange for EFI-related code to be compiled away
From: David Mosberger <davidm@napali.hpl.hp.com>
There is some EFI-related code which is present in the ia64 build but is not
needed: variable efi_enabled is always zero.
The patch fiddles with the efi_enabled definition to arrange for
`efi_enabled' to be constant zero or constant one in those situations where
this can be guaranteed.
Andrew Morton [Mon, 19 Jan 2004 13:13:05 +0000 (05:13 -0800)]
[PATCH] ext3: fix determination of inode journalling mode
The test for whether an inode is using journalled, ordered or writeback data
is incorrect and can lead to ext3_set_aops() giving the inode the wrong set
of address_space_operations. Fix. (Spotted by Jan Kara).
Andrew Morton [Mon, 19 Jan 2004 13:12:56 +0000 (05:12 -0800)]
[PATCH] Add bdev private field
From: Christoph Hellwig <hch@lst.de>
Currently xfs has a per-bdev (and XFS filesystem uses up to three underlying
block devices) object that Al complained about loudly that it should be gone.
But for that to happen without rewriting half of XFS (and changing layering
in a way that we don't really want) we need an additional fs-private variable
in struct block_device.
Andrew Morton [Mon, 19 Jan 2004 13:12:47 +0000 (05:12 -0800)]
[PATCH] tmpfs readdir does not update dir atime
From: mark@borgerding.net
Access times of tmpfs dirs do not get updated on readdir. This can cause
empty dirs to get tmpwatch'd too early, b/c atime never changes even though
the dir is in use.
Andrew Morton [Mon, 19 Jan 2004 13:12:38 +0000 (05:12 -0800)]
[PATCH] Fix statically declare FIXMAPs
From: Anton Blanchard <anton@samba.org>, me.
Two uses of the FIXADDR_USER_START/END things are problematic:
a) ppc64 wants the FIXADDR area to be at a different location on 32bit and
64bit tasks. On 32bit we want it just below 4GB but that gets in the way
on 64bit. By putting both right at -(some small amount) we can also use
some ppc tricks to get there real quickly (single instruction branches).
b) We assume that FIXADDR_USER_START and FIXADDR_USER_END are constants.
This breaks the UML build.
Fixes:
- Call it all gate. We currently have half the stuff called fixmap and
the other gate, lets be consistent.
- Create in_gate_area(), get_gate_vma() and use it in both places
- Provide defaults for in_gate_area/get_gate_vma, allowing an arch to
override it. (I used CONFIG_* but am open to better suggestions here)
- The /proc/pid/maps vma wasnt marked readable but the get_user
vma was. That sounds suspicious to me, they are now both the same VMA
and so have the same (read,exec) permissions
Andrew Morton [Mon, 19 Jan 2004 13:12:29 +0000 (05:12 -0800)]
[PATCH] Alpha: make prefetch_spinlock() a no-op on UP
From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
When CONFIG_SMP is not set, spinlock_t is an empty structure, so its
address has arbitrary alignment.
The prefetch instructions with unaligned address don't have visible side
effects on alphas with SRM console (except performance degradation) - the
PALcode handles unaligned traps caused by prefetch instructions internally.
However, on old AlphaBIOS/MILO boxes unaligned prefetch leads to unhandled
alignment trap and kernel panic.
Too many users use the p4-clockmod cpufreq driver instead of the more
advanced speedstep-centrino, speedstep-ich or even acpi drivers. All of
the latter (usually) provide voltage scaling, while the p4-clockmod driver
only offers a variant of frequency scaling. So, warn users if they try out
this driver instead.
Also, instead of using a local copy, use the speedstep_lib infrastructure
for detecting the processor speed. Adding the Pentium-M get_frequency
function to that module only costs about 200 bytes in object size.
The following reversion is what fixes my regression. That puts the
sequential read numbers back to the 2.6.0 values of ~140MB/sec (from the
current 2.6.1 values of 14MB/second)...
We were triggering I/O of the `ahead' when we hit the last page in the
`current' window. That's bad because it gives no pipelining at all.
So go back to full pipelining.
It's not at all clear why this change made a 10x difference in NFS
throughput.
This patch initializes zone->{prev,temp}_priority to DEF_PRIORITY.
Otherwise they are left zeroed, and first run of VM scanner thinks that
zones are under enormous stress.
projects / linux / log