Andrew Morton [Tue, 24 Aug 2004 10:32:36 +0000 (06:32 -0400)]
[PATCH] I2O: add functionality to scsi_add_device to preset
From: Markus Lidel <Markus.Lidel@shadowconnect.com>
- Add a new function __scsi_add_device, which has an additional parameter
compared to scsi_add_device. This parameter is used to preset the hostdata
pointer.
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
James Bottomley [Tue, 24 Aug 2004 10:30:22 +0000 (06:30 -0400)]
i20 rewrite
From: Markus Lidel <Markus.Lidel@shadowconnect.com>
generic:
- split i2o_core into several files, grouped by same function
- I2O devices are now registered as devices and show up in sysfs
- the various I2O OSM's (e.g. i2o_scsi) now register in the I2O core
and also use the 2.6 driver mechanism.
- I2O messages will be created in the message frame instead of creating
it in local memory and copying it over later on.
- context list for 64 pointer to 32 context conversion now uses a
double linked list
PCI:
- driver now registers as a PCI device driver and uses probe function to
get the possible controllers. (needed for hotplugging)
- converted DMA handling from pci_* to generic dma_* functions
Block OSM:
- use one request queue per I2O block device instead of one per
controller
- I2O block devices and queues are allocated dynamically and therefore
no more limit of block devices
SCSI OSM:
- corrected bug in SCSI reply function which caused the memory to be
freed before the done function was called.
- one I2O controller registers as one scsi host instead of one scsi host
per channel
- no more ch,id,lun => tid mapping table
Config OSM:
- added ioctl32 for passthru and getiops.
- removed ioctl_html
Documentation:
- removed TODO entries from README
- moved docs under Documentation/i2o
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
James Bottomley [Sat, 21 Aug 2004 14:30:38 +0000 (10:30 -0400)]
fix sym2 negotiation
The problems with domain validation were just the tip of the iceberg in
the sym2 driver. Most of its problems seem to come from an overly
complex set of negotiating rules, which I've swept away with this patch.
I also removed the ability to set parameters in the on-board bios and
have the driver respect them. (this hasn't worked for a while in 2.6
because after the driver sets them, Domain Validation resets them
again).
Finally, there was a really nasty bug where the driver negotiates
improperly when turning off DT clocking. If you simply turn it off, the
driver originally fell back to using the old WDTR/SDTR method of
negotiation. However, since it thought the bus was already wide, it
only emitted a SDTR, which causes the device to reset from wide to
narrow. Hence the driver thinks the device is wide and the device
thinks it is narrow => boom.
I redid the negotiation to predicate PPR messages on whether the device
claims support for them or not.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
- cleanup checks in ->queuecommand, we only get here either for
inquiry or a found device now
- DCBmap in the acb is gone, was only used for debug prints after
the prevous changes
- kill some more debugging keyed of by ->scan_devices
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
hrrible code like all proc_info implementations and no really usefull
information. We might want to add sysfs attributes if some users really
miss anything.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
James Bottomley [Thu, 19 Aug 2004 19:03:22 +0000 (15:03 -0400)]
[PATCH] fix for Domain Validation hang on some devices with sym_2
There's a bad hang where the driver locks the system solid trying to do
domain validation with certain devices. The one I've managed to
reproduce it with is a Quantum Atlas.
What happens is that setting the offset to zero is an async negotiation
message. However, the driver still seems to have DT set (which is
illegal). Most devices just reject this as stupid, but the Quantum
seems to try to obey it and hangs the bus.
The simple fix is to reset all PPR options when the offset is set to
zero.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Brian King [Thu, 19 Aug 2004 13:39:03 +0000 (09:39 -0400)]
[PATCH] Allow TCQ depth to be lowered properly
Ran into a couple small issues with the patch. First,
blk_queue_resize_tags wasn't getting exported, so I sent Jens a patch to
fix this, which he has now sent upstream. Second, the comment above
blk_queue_resize_tags says the queue_lock must be held when calling this
routine. Attached is an updated patch that grabs the lock. Other than
that, it looks good.
James Bottomley wrote:
> On Tue, 2004-08-03 at 10:50, Brian King wrote:
>>Currently, it is possible to call scsi_activate_tcq with a small queue depth,
>>then later call scsi_adjust_queue_depth with a larger queue depth. This results
>>in the scsi layer having a larger queue depth than the block layer knows about.
>>This results in these additional commands being issued as untagged ops rather than
>>tagged ops. This patch changes scsi_activate_tcq to call blk_queue_init_tags with
>>the maximum supported number of tags so this cannot occur.
>
>
> Sorry, been away at conferences with not enough time to remember what
> went on here.
>
> The reason it looks the way it does is historical...when the blk layer
> tcq interfaces were created, there was no way to resize the queue. Jens
> later added resize (for me) and I forgot to incorporate it into the
> code.
>
> Another small point is that the max number of tags can be greater than
> 256. 256 is a SPI limit only (and even the qla1280, a SPI card which
> could use the tag as its global queue index would take > 256). The
> limit in scsi_adjust_queue_depth has long since been obsoleted by our
> dynamic command allocation.
>
> I think the attached should work correctly (as long as it compiles...I
> coded it up on the flight home).
Signed-off-by: Brian King <brking@us.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Have been deprecated for a while now. We should make the kernel
complain when a program actually uses one of them, so users have had
adequate warning before they are removed.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Andrew Morton [Wed, 18 Aug 2004 20:04:31 +0000 (16:04 -0400)]
[PATCH] megaraid build fix
drivers/scsi/megaraid/megaraid_mm.c: In function `mraid_mm_init':
drivers/scsi/megaraid/megaraid_mm.c:1069: `mraid_mm_compat_ioctl' undeclared (first use in this function)
drivers/scsi/megaraid/megaraid_mm.c:1069: (Each undeclared identifier is reported only once
drivers/scsi/megaraid/megaraid_mm.c:1069: for each function it appears in.)
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Mike Anderson [Mon, 16 Aug 2004 18:53:00 +0000 (14:53 -0400)]
[PATCH] reorder call in scsi_remove_host
This patch against scsi-misc-2.6 reorders a call to scsi_forget_host in
the scsi_remove_host function. This removes the error message
"Synchronizing SCSI cache..." on rmmod of a scsi host driver module as
shown in example output 1 and 2 below.
I had previous created a much more complicated patch to work around this
problem. In response Christoph mention a simpler solution (pointer to
thread below) which is this patch.
James Bottomley [Mon, 16 Aug 2004 14:50:36 +0000 (10:50 -0400)]
MPT Fusion driver 3.01.15 update
Highlights of this release:
- Patch provided by Christoph Hellwig to remove the isense code.
- Fix compile errors when CONFIG_PROC_FS=n.
- A fix for the module parameter "mptscsih" which was not being exported.
- The port of the 2.05.17 thru 2.05.23 of the lk 2.4 mpt driver.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Switch sd.c device number allocation to use idr, this limits memory
usage for lowend setups and highend setups are only limited by the
available names now.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
James Bottomley [Sat, 14 Aug 2004 15:02:17 +0000 (11:02 -0400)]
AUTOSENSE bug in NCR5380.c
From: Kenn Humborg <kenn@linux.ie>
round line 2470 in NCR5380.c, if a command fails, and AUTOSENSE is on,
the current command is converted into a REQUEST_SENSE command and
put at the top of the request queue. Part of this setup, is setting
up cmd->SCp to point at the sense_buffer, so that the received sense
data goes straight into the sense buffer.
Around line 1730, NCR5380_select() calls initialize_SCp() which ends
up clobbering cmd->SCp, and the sense data get written into the
original request buffer.
This is what happens if cmd->use_sg = 0. I haven't looked at what
happens if use_sg is non-zero, but I expect the effect will be the same.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Mark Haverkamp [Sat, 14 Aug 2004 14:50:45 +0000 (10:50 -0400)]
[PATCH] aacraid driver update
Here are some changes from Adaptec for the AACRAID driver.
Change the pae_support flag to dac_support. This was suggested sometime
last year and never made it in.
Fix some cast problems in pci_set_dma_mask. Was casting the mask to
dma_addr_t when it should be a u64.
Fix SCp.ptr problem, should be SCp.dma_handle.
Applies to the scsi-misc bk tree.
Signed-off by: Mark Haverkamp <markh@osdl.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Andrew Vasquez [Sat, 14 Aug 2004 14:28:32 +0000 (10:28 -0400)]
[PATCH] Re: 2.6.8-rc3-mm2: Debug: sleeping function called from invalid
> Andrew Vasquez wrote:
>
> >
> >This allocation should be done with GFP_ATOMIC flags. The attached
> >patch should apply cleanly to any recent kernel
> >
>
> and seems to work fine.
>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Adrian Bunk [Sat, 14 Aug 2004 14:26:58 +0000 (10:26 -0400)]
[PATCH] SCSI gdth: kill #define __devinitdata
I got the following warning in 2.6.8-rc3-mm2:
<-- snip -->
...
CC drivers/scsi/gdth.o
drivers/scsi/gdth.c:622:1: warning: "__devinitdata" redefined
In file included from include/linux/moduleparam.h:4,
from include/linux/module.h:20,
from drivers/scsi/gdth.c:375:
include/linux/init.h:227:1: warning: this is the location of the
previous definition
...
<-- snip -->
The #define in question seems bogus, and the following patch simply
removes it:
Signed-off-by: Adrian Bunk <bunk@fs.tum.de> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Brian King [Sat, 14 Aug 2004 14:11:42 +0000 (10:11 -0400)]
[PATCH] ipr: replace schedule_timeout() with msleep()
From: Nishanth Aravamudan <nacc@us.ibm.com>
Subject: [PATCH] scsi/ipr: replace schedule_timeout() with msleep()
Description: Use msleep() instead of schedule_timeout() to
guarantee the task delays for the desired time.
Signed-off-by: Brian King <brking@us.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Brian King [Sat, 14 Aug 2004 14:09:35 +0000 (10:09 -0400)]
[PATCH] ipr: Dead adapter I/O hang fix
The following patch fixes a hang in i/o that could occur if an
adapter was ever declared "dead" by the ipr driver due to repeated
failed attempts to revive the card. The patch now allows ipr to fail
new commands when in this state rather than endlessly return
SCSI_MLQUEUE_HOST_BUSY.
Signed-off-by: Brian King <brking@us.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Brian King [Sat, 14 Aug 2004 14:08:08 +0000 (10:08 -0400)]
[PATCH] ipr: Properly enable/disable TCQ
This patch correctly enables tagged command queuing for the ipr driver.
I had misinterpreted scsi_mid_low_api.txt. The following patch has the
appropriate scsi_activate_tcq/scsi_deactivate_tcq calls.
Signed-off-by: Brian King <brking@us.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Brian King [Sat, 14 Aug 2004 14:03:26 +0000 (10:03 -0400)]
[PATCH] ipr: Use kref instead of a kobject
The following patch converts ipr to use a kref rather than a kobject to
do reference counting on an internal data structure. The added overhead
of a kobject is not needed.
Signed-off-by: Brian King <brking@us.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Brian King [Sat, 14 Aug 2004 14:02:52 +0000 (10:02 -0400)]
[PATCH] ipr: minor fixes and assorted nit
From: Francois Romieu <romieu@fr.zoreil.com>
Subject: [PATCH 2.6.7-mm3] ipr: minor fixes and assorted nit
- balance pci_enable_device() with pci_disable_device() where appropriate;
- pci_release_regions() replaces release_mem_region();
- ipr_alloc_mem() can not simply issue a call to ipr_free_mem() when
something goes wrong as it would lead to pci_free_consistent() of
unset data. Let ipr_alloc_mem() carefully release whatever it has
allocated instead;
- no need to memset(..., 0, ...) an area returned by pci_alloc_consistent;
- ipr_probe_ioa:
+ DMA_32BIT_MASK for all;
+ error path rework (includes bug fix when ipr_alloc_mem fails);
- ipr_init() can fail: return adequate status code.
Signed-off-by: Brian King <brking@us.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Brian King [Sat, 14 Aug 2004 14:01:31 +0000 (10:01 -0400)]
[PATCH] ipr: Properly retry aborted reponse
The ipr device driver runs tagged queuing with QERR=1. When a check
condition occurs on a device running tagged queuing, the other queued
commands get aborted by the ipr driver and will be returned by the
adapter with the IPR_IOASC_ABORTED_CMD_TERM_BY_HOST response. These
commands should be retried by the midlayer and their retry counter not
decremented.
Signed-off-by: Brian King <brking@us.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Brian King [Sat, 14 Aug 2004 13:58:14 +0000 (09:58 -0400)]
[PATCH] ipr: Use cancel all instead of abort task
Currently, ABORT_TASK does not work properly on ipr adapters. It results in
timeouts and eh ends up getting escalated to eh_host_reset to recover.
The adapters are supposed to be fixed to properly handle this at some
point in the future, but until that updated microcode is available,
we need to send a cancel all to the device instead.
Signed-off-by: Brian King <brking@us.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
I might be wrong, but it looks like the attached patch has still not been
applied, although it is pretty important - it fixes error handling in
tmscsim. E.g., it was reported, that this patch fixes a problem with
tmscsim in 2.6.7 with a SCSI-3 scanner, that doesn't support REPORT LUNS
command.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Adrian Bunk [Fri, 13 Aug 2004 08:21:53 +0000 (04:21 -0400)]
[PATCH] SCSI nsp32.c: missing parts of inline removal patch
The SCSI tree as included in 2.6.8-rc2-mm2 only removes the inline's
from the functions prototypes, but the part of my original patch that
also removes the inline's from the functions was lost.
Signed-off-by: Adrian Bunk <bunk@fs.tum.de> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Andrew Morton [Thu, 29 Jul 2004 12:48:36 +0000 (08:48 -0400)]
[PATCH] Fix double reset in aic7xxx driver
From: Joe Korty <joe.korty@ccur.com>
Fix occasional PCI bus parity errors on the Dell PowerEdge 4600 during
boot.
Symptoms: The LCD display would turn orange and display "PCI SYSTEM E13F5",
and the following message would appear in /var/log/dmesg: "Uhhuh. NMI
received. Dazed and confused, but trying to continue".
By inserting a PCI card with a PDC20268 IDE controller and attaching to
that a Sony DRU-510A DVD RW burner with an unloaded tray, the failure can
be made to happen on every boot.
Cause: The aic7xxx driver was resetting the onboard AIC7891 SCSI controller
while waiting for a previous reset to complete. This second reset confuses
the controller causing it to put bad data onto the PCI bus.
This is a backport of a RedHat 2.4.21-15.ELsmp fix. A letter discussing
this problem, or one very close to it, may be found at:
Matt Domsch [Wed, 28 Jul 2004 13:37:56 +0000 (09:37 -0400)]
[PATCH] add MODULE_VERSION to drivers/scsi
On Thu, Jul 22, 2004 at 01:28:23PM +0100, Matthew Wilcox wrote:
> > +#define SYM_VERSION "2.1.18j"
> > +#define SYM_DRIVER_NAME "sym-" SYM_VERSION
>
> Umm. No. This is ridiculous. I'm not having a 51 line copyright message
> with 2 lines of #define. It's not even clear to me that these two lines
> have artisitic merit. How about putting these defines in sym_defs.h,
> at the top? It's already included in both sym_glue.c and sym_hipd.c by
> being included by sym_glue.h.
Indeed, point well taken. Done, they're now at the top of defines in
sym_defs.h, and I've updated my BK tree accordingly.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Dave Boutcher [Wed, 28 Jul 2004 13:33:44 +0000 (09:33 -0400)]
[PATCH] ibmvscsi driver v1.5.1
Based on comments from hch and jejb, an update to the ibmvscsi
driver patch. Primarily style issues, though the removal of
gratuitous casting lead to some significant refactoring
of functions.
- Moved #include <asm/...> after #include <linux/...>
- removed the map_direct_data and map_indirect_data and moved
the function inline
- Fixed function declaration style issues (static on a line by
itself)
- Removed bogus cast from dma_map_single
- Moved setting of data transfer direction to a single helper
function
- Fixed up some gratuitous casting of types
- Collapsed a couple of other functions inline
- Removed bogus check for NULL from remove
- Removed the "evt_struct_for" routine as being needlessly obfuscatory
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
I looked at those 3 functions. dc390_EnableMsgOut_Abort is called 5 times
in the code and is 0x30 bytes long (as compiled with 3.3.2), so,
uninlining it, probably, makes most sense. The other 2 functions are
called only ones each and from the interrupt, so, I applied the
"alternative approach" to them - moved above the calling functions.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Adrian Bunk [Wed, 28 Jul 2004 13:05:48 +0000 (09:05 -0400)]
[PATCH] SCSI nsp32.c: remove inlines
Trying to compile drivers/scsi/nsp32.c in 2.6.8-rc1-mm1 using gcc 3.4
results in compile errors starting with the following:
<-- snip -->
...
CC drivers/scsi/nsp32.o
drivers/scsi/nsp32.c: In function `nsp32_prom_start':
drivers/scsi/nsp32.c:270: sorry, unimplemented: inlining failed in call
to 'nsp32_prom_set': function body not available
drivers/scsi/nsp32.c:3348: sorry, unimplemented: called from here
drivers/scsi/nsp32.c:270: sorry, unimplemented: inlining failed in call
to 'nsp32_prom_set': function body not available
drivers/scsi/nsp32.c:3349: sorry, unimplemented: called from here
drivers/scsi/nsp32.c:270: sorry, unimplemented: inlining failed in call
to 'nsp32_prom_set': function body not available
drivers/scsi/nsp32.c:3350: sorry, unimplemented: called from here
drivers/scsi/nsp32.c:270: sorry, unimplemented: inlining failed in call
to 'nsp32_prom_set': function body not available
drivers/scsi/nsp32.c:3351: sorry, unimplemented: called from here
drivers/scsi/nsp32.c:270: sorry, unimplemented: inlining failed in call
to 'nsp32_prom_set': function body not available
drivers/scsi/nsp32.c:3353: sorry, unimplemented: called from here
make[2]: *** [drivers/scsi/nsp32.o] Error 1
<-- snip -->
The patch below removes the inlines from nsp32_prom_{get,set}.
An alternative approach would be to move the functions above the place
where they are called the first time.
Signed-off-by: Adrian Bunk <bunk@fs.tum.de> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Adrian Bunk [Wed, 28 Jul 2004 13:00:16 +0000 (09:00 -0400)]
[PATCH] SCSI dc395x.c: fix inline compile errors
Trying to compile drivers/scsi/dc395x.c in 2.6.8-rc1-mm1 using gcc 3.4
results in compile errors starting with the following:
<-- snip -->
...
CC drivers/scsi/dc395x.o
drivers/scsi/dc395x.c: In function `dc395x_handle_interrupt':
drivers/scsi/dc395x.c:388: sorry, unimplemented: inlining failed in call
to 'enable_msgout_abort': function body not available
drivers/scsi/dc395x.c:1740: sorry, unimplemented: called from here
make[2]: *** [drivers/scsi/dc395x.o] Error 1
<-- snip -->
The patch below moves enable_msgout_abort above the place where it is
called the first time and removes the bogus inline from the prototype of
set_xfer_rate (the function itself isn't marked as inline).
An alternative approach would be to remove the inline from
enable_msgout_abort.
Signed-off-by: Adrian Bunk <bunk@fs.tum.de> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Alexander Viro [Mon, 26 Jul 2004 14:04:13 +0000 (07:04 -0700)]
[PATCH] broken stuff marked as such in Kconfig
a) ppc KGDB builds only on two subarch; say so in Kconfig
b) ide-pmac.c can't be a module; make it dependent on IDE=y.
c) a bunch of isdn drivers is broken on ppc; marked as such
d) oaknet is broken; marked as such (includes on files that do not
exist, etc.)
e) buslogic and cyber2000 are broken on sparc64
f) s3trio framebuffer is broken
g) usual 8250-based serial is broken on sparc64; in principle it might
be worth supporting (there are PCI cards of that sort), for now marked as
broken (no asm/serial.h, to start with).
Alexander Viro [Mon, 26 Jul 2004 14:03:51 +0000 (07:03 -0700)]
[PATCH] asm-ppc/reg.h namespace pollution fixes
asm-ppc/reg.h defines pollutes namespace like there's no tomorrow;
among other things there are
LR
SR0...SR15
DEC
etc.
That breaks quite a few drivers that should otherwise work on ppc. SR...
and LR were never used by ppc code; commented out in reg.h (note that
they are just aliases for SPRN_SR... and SPRN_LR). RPA commented out and
its instances in ppc code (all four of them) replaced with SPRN_RPA. Ditto
for DEC. The rest of the offenders (DAR and PVR) are left alone for now and
#undef'ed in drivers in question.
We probably want to rip all these guys out of reg.h and convert ppc users
to SPRN_... forms - file ends up included in alot of places and namespace
pollution like that is a Bad Thing(tm).
Alexander Viro [Mon, 26 Jul 2004 14:03:29 +0000 (07:03 -0700)]
[PATCH] pointer-to-int conversion fixes
Assorted pointer-to-int fixes:
a) some places want to take pointer modulo alignment or extract
integer that was cast to pointer (which is legitimate), but do that via
wrong cast, triggering sparse warnings.
b) usual %x (int)ptr -> %p ptr fixes
Alexander Viro [Mon, 26 Jul 2004 14:02:32 +0000 (07:02 -0700)]
[PATCH] cciss compat ioctl fix
cciss compat ioctls were broken (mixing kernel and userland pointers);
fixed (and cleaned up) by switch to compat_alloc_user_space() and elimination
of set_fs().
Alexander Viro [Mon, 26 Jul 2004 14:02:20 +0000 (07:02 -0700)]
[PATCH] annotations for arch/ppc and include/asm-ppc
Usual set - explicit -D<arch>=1 for sparse, __sighandler_t / __sigrestore_t
annotated, annotations in arch/ppc/kernel/*, etc. - same as for other platforms
Alexander Viro [Mon, 26 Jul 2004 14:01:57 +0000 (07:01 -0700)]
[PATCH] CONFIG_MCOUNT fix for sparc64
CONFIG_MCOUNT on sparc64 is currently broken; we have both mcount and _mcount
declared (and aliased to each other), but end up exporting the wrong one. As
the result, with that option all modules get unresolved symbol.
Alexander Viro [Mon, 26 Jul 2004 14:00:34 +0000 (07:00 -0700)]
[PATCH] NULL noise removal in drivers/net/*
That definitely duplicates a bunch of stuff in pending patches from various
folks, but since it's all trivial 0->NULL replacements and patches are still
not submitted and/or merged...
Alexander Viro [Mon, 26 Jul 2004 14:00:21 +0000 (07:00 -0700)]
[PATCH] mtd fixes
Assorted mtd fixes.
a) NULL noise removal
b) %p pointer instead of %x (int)pointer in printks
c) missed iovec->kvec replacements (basically, fixing merge problems)
d) fixed type for (unused) last argument in doc_{read,write}_ecc()
e) sanitized some comparisons.
Alexander Viro [Mon, 26 Jul 2004 14:00:10 +0000 (07:00 -0700)]
[PATCH] impi annotation
drivers/char/ipmi/* annotated, structure shared between kernel and
userland (ioctls) split in two.
ACPI callback in the same code used to have wrong type - it should've been
void (...), not u32 (...). Fixed.
projects / linux / log