Andrew Morton [Mon, 15 Mar 2004 23:20:29 +0000 (15:20 -0800)]
[PATCH] reiserfs: fix null pointer deref
From: Chris Mason <mason@suse.com>
From: Jeff Mahoney <jeffm@suse.de>
fsstress manages to setup a sequence of events that allow an attempt to
perform direct-io on a tail. bh_result->b_page == NULL, which causes the
PageLocked and PageWriteback checks to perform a NULL deref, causing the
oops.
Andrew Morton [Mon, 15 Mar 2004 23:20:05 +0000 (15:20 -0800)]
[PATCH] fbdev: character drawing enhancement.
From: James Simmons <jsimmons@infradead.org>
This patch merges two of the drawing functions. The patch uses aligned
transfers when possible even on displays where the characters are not byte
align. Tested on my my laptop for 12 bit width fonts and 8 bit wide fonts.
It works very nicely.
Andrew Morton [Mon, 15 Mar 2004 23:19:52 +0000 (15:19 -0800)]
[PATCH] page_referenced() simplification
There's no point in calling mark_page_accessed() here. The page is never on
the LRU so all mark_page_accessed() will do is to set PG_referenced, which we
immediately clear again.
Andrew Morton [Mon, 15 Mar 2004 23:19:29 +0000 (15:19 -0800)]
[PATCH] flush_scheduled_work() deadlock fix
Because keventd is a resource which is shared between unrelated parts of the
kernel it is possible for one person's workqueue handler to accidentally call
another person's flush_scheduled_work(). thockin managed it by calling
mntput() from a workqueue handler. It deadlocks.
It's simple enough to fix: teach flush_scheduled_work() to go direct when it
discovers that the calling thread is the one which should be running the
work.
Note that this can cause recursion. The depth of that recursion is equal to
the number of currently-queued works which themselves want to call
flush_scheduled_work(). If this ever exceeds three I'll eat my hat.
Andrew Morton [Mon, 15 Mar 2004 23:19:18 +0000 (15:19 -0800)]
[PATCH] selinux: fix compute_av bug
From: Stephen Smalley <sds@epoch.ncsc.mil>
This patch fixes a bug in the SELinux compute_av code; the current code
yields the right access computation but can cause unnecessary (but
harmless) processing to occur when transition permission wasn't granted in
the first place by the TE configuration. Thanks to Chad Hanson of TCS for
reporting the bug.
Andrew Morton [Mon, 15 Mar 2004 23:19:07 +0000 (15:19 -0800)]
[PATCH] kbuild: fix modpost when used with O=
From: Sam Ravnborg <sam@ravnborg.org>
modpost or to be more specific sumversion.c was not behaving correct when
used with O= and MODULE_VERSION was used. Previously it failed to use
local .h when calculation the md-sum in case of a O= build.
The following patch introduces the following:
- A generic get_next_line()
- Check that the topmost part of the directory matches
- Using strrch when checking for file with suffix .o
- Use NOFAIL for allocations in sumversion
- Avoid memory leak in new_module
The generic get_next_line will pay off when Andreas implmentation of
storing symbol addresses in a seperate file is introduced.
ver_linux hasn't displayed binutils version right for some time. This patch
corrects that and preserves the old behaviour as well, as suggested by Rusty.
Andrew Morton [Mon, 15 Mar 2004 23:16:02 +0000 (15:16 -0800)]
[PATCH] ide-scsi error handling fixes
From: Willem Riede <wrlk@riede.org>
The patch revises the error handling in ide-scsi, fixing the scheduling
while locked issues, and make it work properly, at least for me...
Specific changes in this patch:
- introduce idescsi_expiry, a timeout routine for the ide subsystem,
which simply flags the fact that the command timed out, but postpones
any other action until either the command still finishes on its own
(unlikely?) or the scsi error handler kicks in;
- introduce idescsi_atapi_error and idescsi_atapi_abort, error routines
for the ide subsystem, which are modeled after those of ide-cd, but
take only minimal effort to recover, leaving the heavy lifting for
the scsi error handler;
- rewrite (and rename for clarity) idescsi_eh_abort and idescsi_eh_error,
the abort/error routines to be called by the scsi error handler --
this redesign should not have the scheduling while atomic problems
of the old implementation.
- move ide_cdrom_dump_status() from ide-cd.c to ide-lib.c as
ide_dump_atapi_status() and both ide-cd and ide-scsi call it.
- replaces BUG() by WARN_ON()/printk in the error handling code.
- sets TASK_UNINTERRUPTIBLE before schedule_timeout() and moves the host
unlock/lock around the while loop inside the loop in idescsi_eh_reset().
Andrew Morton [Mon, 15 Mar 2004 23:15:51 +0000 (15:15 -0800)]
[PATCH] selinux: Conditional policy extension and MLS detection support
From: Stephen Smalley <sds@epoch.ncsc.mil>
This patch extends the SELinux policy engine to support conditional policy
logic based on a set of policy booleans, allowing well-formed changes to
the policy to be defined within and mediated by the policy itself.
The conditional policy extensions were implemented and contributed by
Tresys Technology.
Userland packages that support these extensions are already available from
nsa.gov/selinux, and backward compatibility is provided for the prior
policy version.
The patch also includes a small change to enable detection of the optional
MLS policy model on a SELinux system and fixes to the conditional policy
extensions to allow the MLS policy to work correctly with them that were
implemented and contributed by Trusted Computer Solutions.
Andrew Morton [Mon, 15 Mar 2004 23:15:05 +0000 (15:15 -0800)]
[PATCH] Fix early parallel make failures
From: Sam Ravnborg <sam@ravnborg.org>
Ingo said:
Starting at around 2.6.4-rc2-mm1, I keep seeing 'scripts/fixdep: Text
file busy' messages when doing a -j10 bzImage build - which seems to
suggest that by the time fixdep is used by the build system it's not
built yet.
Sam said:
I was pretty sure it was something I had caused, so I gave it a spin. What
actually happened was that we tried to build the target 'silentoldconfig'
in parrallel with 'scripts'. Since 'silentoldconfig' started a new make
and then the config target needed 'scripts' we saw two parallel runs.
The way I decided to fix it was to split scripts/ in two parts. The first
part is now the very basic stuff - moved to scripts/basic/. The second
part is dependent on kernel config etc. and kept in scripts/
In the 2.7 timeframe i will redo this initial stuff - it's becoming too
messy for anyone to understand today.
Description:
Fix dependencies in early phases of kernel build. This solves a few
problems nively: modpost is no longer rebuild twicewhen reaching the
'target' state 'make -j10' now works nicely again
The patch is rather large due to the following file moves:
mkdir scripts/basic
mv scripts/fixdep.c scripts/basic
mv scripts/split-include.c scripts/basic
mv scripts/docproc.c scripts/basic
The g5 iommu code would fill the "iommu_table" member of whatever
device node was pointed to by pcidev->sysdata during boot. However,
the ppc64 kernel fills that with a pointer to the PHB node which is
later replaced "lazily" with a pointer to the real node when calling
pci_device_to_OF_node(). In this case, we were thus "losign" the
iommu_table pointer. Typical symptom: loss of the SATA when looking
at it's /proc entry.
This fixes it by forcing the update to the final sysdata pointer
when filling up the iommu_table pointers. The "lazy" thing is useless
on pmac anyway.
Keith Owens [Mon, 15 Mar 2004 15:31:37 +0000 (07:31 -0800)]
[PATCH] ia64: Decode salinfo oemdata for SN2 via PROM
SN2 platforms provide oemdata in salinfo records. The decode of that
oemdata is done via prom routines. This patch provides the interface
from user space through the kernel into the prom to do the oem decode.
David Mosberger [Mon, 15 Mar 2004 15:30:13 +0000 (07:30 -0800)]
ia64: Based on patch by Keith Owens: put stop bit to work around GCC problem.
Apparently GCC sometimes fails to insert a stop-bit when re-using p14
after the spinlock directives, even though the register is clearly marked
as "clobbered".
Use the proper (and cleaner) probing API instead of the old
scsi_module.c hack, don't use the typedefs I plan to kill in 2.7 and
mark everything static
Bjorn Helgaas [Mon, 15 Mar 2004 14:34:08 +0000 (06:34 -0800)]
[PATCH] ia64: update ia64/Kconfig
This Kconfig patch basically just makes ia64 look a little more like i386:
- moves system type above processor type
- moves PM & ACPI to a new top-level menu
- moves PCI/PCMCIA to a new top-level menu
Jens Axboe [Mon, 15 Mar 2004 13:24:51 +0000 (05:24 -0800)]
[PATCH] sys_swapon bad arg causing slab corruption
There's an error in sys_swapon() that can cause slab corruption if you
pass in a bad specialfile pointer. getname() then returns
ERR_PTR(-EFAULT), but sys_swapon() doesn't clear name before calling
putname() on it (thus freeing 0xfffffff2, corrupting slab). An ltp test
case repeatedly crashed in later tests due to thus, irk.
Paul Wagland [Mon, 15 Mar 2004 13:15:14 +0000 (05:15 -0800)]
[PATCH] Set module owner in megaraid driver
This bug was discussed on linux-scsi a few weeks back, but it appears to
have slipped through the cracks. This fix was originally proposed by
Christoph Hellwig, but I am reposting it, since I have the hardware :-)
Anyway, the problem that this fixes is that megaraid doesn't set the
moduler owner for the host_template, this means that the module can be
removed, even when it is in use.
Andrew Morton [Mon, 15 Mar 2004 13:02:26 +0000 (05:02 -0800)]
[PATCH] generic 32 bit emulation for System-V IPC
From: Arnd Bergmann <arnd@arndb.de>
Adds a generic implementation of 32 bit emulation for IPC system calls. The
code is based on the existing implementations for sparc64, ia64, mips, s390,
ppc and x86_64, which can subsequently be converted to use this.
Jeff Garzik [Mon, 15 Mar 2004 06:03:56 +0000 (01:03 -0500)]
[libata] disable clustering by default, whitespace cleanups
Disable SCSI's clustering of S/G entries, typically reducing overall
S/G list size. Although ATA S/G tables are getting smarter (64-bit
address, 32-bit length, no DMA boundary besides 4G itself), working
harder to generate large byte sizes for each S/G size is not necessarily
in our best interest:
* SATA consists of frames, much like ethernet, called "FIS". A
Data FIS consists of up to 2048 dwords (8K) of data. We don't want
generate large byte sizes in S/G entries, just to have the host controller
break them up again into smaller chunks.
* Reduces the possibility that ata_fill_sg (libata-core.c) must split
an S/G into two pieces, because it straddles a 64K boundary.
* Reduces the possibility that FIS-related errata workarounds
must be enabled. One such exists in the Silicon Image driver (sata_sil),
which is currently worked around by limiting the max-sectors-per-request
to 15.
This patch makes the w83781d driver preserve fan_min settings when the
user changes fan_divs. This isn't done "by default" because the actual
fan min value (in RPMs) depends on both the fan_min register and the
fan_div register. Only two drivers handle it properly at the moment as
far as I know (lm78 and asb100). Several other drivers would need to be
fixed the same way, but well, once at a time ;)
Tested on my AS99127F rev.1.
Credits go to Philip Pokorny, since I think I remember he is the one who
introduced the method in the lm78 driver in the first place.
This tends to increase the size of the three set_store_regs_fan_div
functions, and I am considering refactoring them at some point. Later
though.
Note that in any case, the worst that could happen (but then again, it
cannot happen) is that the chip name would be set to an empty string,
which doesn't hurt much.
The patch also cleans up a few things in it87, w83627hf and w83781d,
which are tightly related to the rest of the changes and necessary for
them to be safe.
it87: There is only really one "kind" in this driver, so I removed all
references to other kinds.
w83627hf: The driver did not handle unknown chips.
w83781d: The user shouldn't be allowed to force a kind that doesn't
match the chip's bus type (I2C or ISA). The code was not meant to handle
that case, although no check was done so far.
Jean Delvare [Mon, 15 Mar 2004 05:08:29 +0000 (21:08 -0800)]
[PATCH] I2C: fix forced i2c chip drivers have no name
I just noticed that I am doing something wrong in the i2c chip drivers I
ported to Linux 2.6. If these drivers are forced to a specific chip type
("kind" as we call it internally), then the device doesn't have its name
set (and defaults to an empty string).
Affected drivers: gl518sm, lm83, lm90, w83l785ts.
I could verify the problem on my ADM1032 chip (lm90 driver). I also
verified that the proposed patch fixes the issue.
You may notice that I fix the problem differently for gl518sm and
w83l785ts on the one hand, and lm83 and lm90 on the other hand. This is
because the first two drivers are not expected to support more a single
chip in the future, while lm90 already does and lm83 could someday (for
example, support for the LM82 could be added on request).
When Tun initialization fails it shouldn't obscure the error return,
There are several reasons it could fail, and when diagnosing user problems
the error code might provide more info.
projects / linux / log