John Rose [Tue, 15 Jun 2004 13:19:55 +0000 (06:19 -0700)]
[PATCH] insert_resource fix
I noticed that insert_resource() incorrectly handles the case of an
existing parent resource with the same ending address as a newly added
child. This results in incorrect nesting, like the following:
PIO handlers under CONFIG_IDE_TASKFILE_IO=n are never used for bio
based requests (rq->bio is always NULL) so we can use rq->buffer
directly instead of calling ide_[un]map_buffer().
[PATCH] ide: cleanup taskfile PIO handlers (CONFIG_IDE_TASKFILE_IO=n)
These handlers are nowadays used only for REQ_DRIVE_TASKFILE
requests (rq->bio is always NULL) which aren't retried et all so
remove code 'rewinding' rq->current_nr_sectors and some FIXMEs.
[PATCH] ide: fix ide-cd to not retry REQ_DRIVE_TASKFILE requests
'cat /proc/ide/hdx/identify' generates REQ_DRIVE_TASKFILE request
(for WIN_PIDENTIFY command) even for devices controlled by ide-cd.
All other drivers don't try to retry such requests.
- do not unregister ide-pnp driver while detaching random
IDE device from random IDE device driver if IDE is modular
(somebody added this in 2.3.51)
- clear 'hw_regs_t hw' allocated from stack
- mark idepnp_init() with __init
- use ide_std_init_ports() instead of ide_setup_ports()
The IDE sparse fixups cause 2 warnings (unused variables `val' and
`reg') on m68k and APUS. However, the reason why this code was
commented out is gone. So just remove the special case.
Chris Wedgwood [Mon, 14 Jun 2004 16:01:29 +0000 (09:01 -0700)]
[PATCH] stat nlink resolution fix
Some filesystems can get overflows when their link-count exceeds
65534. This patch increases the kernels internal resolution for this
and also has a check for the old-system call paths to return and error
(-EOVERFLOW) as required (as suggested by Al Viro).
Signed-off-by: Chris Wedgwood <cw@f00f.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Harald Welte [Mon, 14 Jun 2004 10:30:31 +0000 (03:30 -0700)]
[NETFILTER]: Prevent orphan expectations.
This patch fixes orphaned expectations, which can occur when helpers create
expectations for unconfirmed conntracks and the packet is dropped before
the conntrack is confirmed.
Signed-off-by: Phil Oester <kernel@linuxace.com> Signed-off-by: Harald Welte <laforge@netfilter.org> Signed-off-by: David S. Miller <davem@redhat.com>
Harald Welte [Mon, 14 Jun 2004 10:28:58 +0000 (03:28 -0700)]
[NETFILTER]: Don't assign new helper after NAT when there are already expectations present.
Tracked down by Raivis Bucis <raivis@mt.lv>
This patch fixes an oops while listing /proc/net/ip_conntrack.
When a helper sets up expectations based on the first packet (tftp),
NAT can still change the packet and cause conntrack to look for a new helper
based on the new tuple. When no helper is found, expectant->helper will be
NULL, which leads to an oops in print_expect().
Only assign a new helper in ip_conntrack_alter_reply() if there are no
expectations.
Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: Harald Welte <laforge@netfilter.org> Signed-off-by: David S. Miller <davem@redhat.com>
Andrew Morton [Mon, 14 Jun 2004 06:16:49 +0000 (23:16 -0700)]
[PATCH] ppc64: fix out_be64
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Patch fixes out_be64 implementation on ppc64 along with a glich in out_be32
(inconsistent) use of barrier.
Signed-off-by: Roland Dreier <roland@topspin.com> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Andrew Morton <akpm@osdl.org>
Andrew Morton [Mon, 14 Jun 2004 06:16:27 +0000 (23:16 -0700)]
[PATCH] Fix nfs writepage behaviour
From: Nick Piggin <nickpiggin@yahoo.com.au>
nfs_writepage() refuses to write back mapped pages at all on the page
reclaim path, causing systems to get locked up when there's a lot of dirty
mmapped data around. The patch changes NFS so that it will start I/O
against these pages.
The code as it stands is designed to defer writeout to pdflush which can do
larger, more efficient I/Os. But there shouldn't be much traffic by this
path, and going slow is better than not going at all.
Andi Kleen [Mon, 14 Jun 2004 06:06:51 +0000 (23:06 -0700)]
[PATCH] Fix x86-64 VIA systems with IOMMU debug
VIA chipsets are broken and don't work with IOMMU enabled. For some mysterious
reason (the IOMMU logic is actually in the CPU) they manage to corrupt all
data going through the aperture to PCI devices.
There was a workaround previously that enabled the slower softmmu when VIA is
detected on the normal IOMMU path (when there is more than 3GB of memory). But
CONFIG_IOMMU_DEBUG took a short cut that was not handled, which ended up with
VIA systems not booting when this option is enabled.
This patch enables the workaround with CONFIG_IOMMU_DEBUG/iommu=force too
Ben Collins [Sun, 13 Jun 2004 06:11:37 +0000 (02:11 -0400)]
ieee1394: CSR1212 Extended ROM bug fixes
- Use vmalloc instead of kmalloc
- Change delayed_reset_bus() to operate in a work_queue instead of a timer
interrupt.
- Fix hpsb_allocate_and_register_addrspace() to not allocate space on top
of already allocated space.
- Fix problems in csr1212.c filling ConfigROM images when extend ROMs are
present.
Signed-off-by: Steve Kinneberg <kberg@linux1394.org> Signed-off-by: Ben Collins <bcollins@debian.org>
- /dev/watchdog is single open only: make sure that the bit that
prevents a second open is cleared as the last instruction of the
release code
- Change the way we set the original heartbeat code
- Make sure that /dev/temperature get's registered before /dev/watchdog
- /dev/watchdog is single open only: make sure that the bit that
prevents a second open is cleared as the last instruction of the
release code
- Change the way we set the original heartbeat
- Make sure that /dev/temperature get's registered before /dev/watchdog
- Make pcwd_keepalive return 0 on success.
- /dev/watchdog is single open only: make sure that the atomic that
prevents a second open is cleared only as the last instruction of the
release code.
Kenneth W. Chen [Sat, 12 Jun 2004 23:49:20 +0000 (16:49 -0700)]
[PATCH] ia64: fix race in fsys_bubble_down to avoid fp-register corruption
The fast system-call fall-back-path has a race: it reads PSR, modifies
some bits, then writes back the new PSR. Unfortunately, the contents
of PSR may change between reading and writing it. For example, an
interrupt could occur which could trigger a context-switch. The
context-switch might in turn flush the floating-point-high (FPH)
partition to memory, clear PSR.MFH, and set PSR.DFH. To prevent this
race, the patch below turns off PSR.I before reading PSR.
This fixes a floating-point corruption problem that was observed on a
system with a libc which has the fast system-call support enabled.
The performance impact is minimal (on the order of a handful of cycles).
Signed-off-by: Kevin Tian <kevin.tian@intel.com> Signed-off-by: Ken Chen <kenneth.w.chen@intel.com> Signed-off-by: Asit Mallick <asit.k.mallick@intel.com> Signed-off-by: David Mosberger <davidm@hpl.hp.com> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Andrew Morton [Sat, 12 Jun 2004 23:45:58 +0000 (16:45 -0700)]
[PATCH] ramdisk: buffer_uptodate fix
I waffled over this for ages. On balance, I think it's best to mark those
bh's as uptodate.
And on reflection, I'm not sure why we go bringing ramdisk blockdev pages
uptodate all over the place anyway. But ramdisk is weird and it passes
testing. Let those dogs sleep.
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Andrew Morton [Sat, 12 Jun 2004 23:45:44 +0000 (16:45 -0700)]
[PATCH] sparse fix for void return in selinux/hooks.c
From: Chris Wright <chrisw@osdl.org>
CHECK security/selinux/hooks.c
security/selinux/hooks.c:1383:34: warning: return expression in void function
security/selinux/hooks.c:3548:30: warning: return expression in void function
CC security/selinux/hooks.o
From: Mika Kukkonen <mika@osdl.org> Signed-off-by: Chris Wright <chrisw@osdl.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Andrew Morton [Sat, 12 Jun 2004 23:44:32 +0000 (16:44 -0700)]
[PATCH] s390: cleanup string functions
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cleanup s390* string functions. This replaces the 31/64 bit assembler
files (strcmp[64].S, strcpy[64].S & strncpy[64].S) with a single string.c
file that uses some inline assemblies to issue the string instructions. In
addition some more of the generic string function got an architecture
dependent implementation.
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Andrew Morton [Sat, 12 Jun 2004 23:44:00 +0000 (16:44 -0700)]
[PATCH] s390: simplify single stepped svc code
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
Introduce a TIF_SINGLE_STEP bit that causes do_debugger_trap to get called
at the end of a system call. This way some code duplication in the program
check handler can get removed.
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Andrew Morton [Sat, 12 Jun 2004 23:42:15 +0000 (16:42 -0700)]
[PATCH] dup_mmap() memory accounting fix
From: Hugh Dickins <hugh@veritas.com>
Oleg's patch was good in that exit_mmap usually does the un-accounting; but
dup_mmap still needs its own un-accounting for the case when it has charged
for a vma, but error before it's inserted into child mm's list.
Andrew Morton [Sat, 12 Jun 2004 23:41:17 +0000 (16:41 -0700)]
[PATCH] fix modprobe_path and hotplug_path sizes and sysctl
From: Andy Whitcroft <apw@shadowen.org>
Both modprobe_path and hotplug_path are arbitrarily sized at 256 bytes and
that size is also expressed directly in the sysctl code. It seems
reasonable to define a standard length and use that for consitancy. This
patch introduces the constant KMOD_PATH_LEN and uses that.
Signed-off-by: Andy Whitcroft <apw@shadowen.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Andrew Morton [Sat, 12 Jun 2004 23:41:03 +0000 (16:41 -0700)]
[PATCH] Update Documentation/filesystems/Locking
From: Anton Altaparmakov <aia21@cam.ac.uk>
A filesystem's ->writepage() implementation nowadays must run either
redirty_page_for_writepage() or the combination of set_page_writeback()/
end_page_writeback(). Failure to do so leaves the page itself marked clean
but it is tagged as dirty in the radix tree (PAGECACHE_TAG_DIRTY). This
incoherency can lead to all sorts of hard-to-debug problems in the
filesystem like having dirty inodes at umount and losing written data.
The patch updates Documentation/filesystems/Locking to reflect this
requirement.
Signed-off-by: Anton Altaparmakov <aia21@cantab.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Andrew Morton [Sat, 12 Jun 2004 23:39:25 +0000 (16:39 -0700)]
[PATCH] vmscan: try harder for GFP_NOFS allocators
Page reclaim bales out very early if reclaim isn't working out for !__GFP_FS
allocation attempts.
It was a fairly arbitrary thing in the first place and chances are the caller
will simply retry the allocation or will do something which is disruptive to
userspace. So remove that code and do much more scanning.
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Andrew Morton [Sat, 12 Jun 2004 23:39:11 +0000 (16:39 -0700)]
[PATCH] vmscan: handle synchronous writepage()
Teach page reclaim to understand synchronous ->writepage implementations.
If ->writepage completed I/O prior to returning we can proceed to reclaim the
page without giving it another trip around the LRU.
This is beneficial for ramdisk-backed S_ISREG files: we can reclaim the file's
pages as fast as the ramdisk driver needs to allocate them and this prevents
I/O errors due to OOM in rd_blkdev_pagecache_IO().
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Andrew Morton [Sat, 12 Jun 2004 23:38:26 +0000 (16:38 -0700)]
[PATCH] Voyager doesn't support MCE
From: William Lee Irwin III <wli@holomorphy.com>
Voyager doesn't compile any of the APIC or IO-APIC -related code in
arch/i386/kernel/ at all -- so it's a logical impossibility that this could
ever work.
Cc: James Bottomley <James.Bottomley@SteelEye.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Andrew Morton [Sat, 12 Jun 2004 23:38:11 +0000 (16:38 -0700)]
[PATCH] numaq mempolicy.c build fix
From: William Lee Irwin III <wli@holomorphy.com>
mm/mempolicy.c: In function `verify_pages':
mm/mempolicy.c:246: warning: implicit declaration of function `kmap_atomic'
mm/mempolicy.c:249: warning: implicit declaration of function `kunmap_atomic'
pte_offset_map() invokes kmap_atomic() via macro, without including the
required header.
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>