Dipankar Sarma [Mon, 23 Aug 2004 05:58:51 +0000 (22:58 -0700)]
[PATCH] rcu: abstracted RCU dereferencing
Use abstracted RCU API to dereference RCU protected data. Hides barrier
details. Patch from Paul McKenney.
This patch introduced an rcu_dereference() macro that replaces most uses of
smp_read_barrier_depends(). The new macro has the advantage of explicitly
documenting which pointers are protected by RCU -- in contrast, it is
sometimes difficult to figure out which pointer is being protected by a given
smp_read_barrier_depends() call.
Signed-off-by: Paul McKenney <paulmck@us.ibm.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Dipankar Sarma [Mon, 23 Aug 2004 05:58:28 +0000 (22:58 -0700)]
[PATCH] rcu: use call_rcu_bh() in route cache
Use call_rcu_bh() in route cache. This allows faster grace periods and avoids
dst cache overflows during DoS testing.
This patch uses the call_rcu_bh() api in route cache code to facilitate
quicker RCU grace periods. Quicker grace periods avoid overflow of dst cache
in heavily loaded routers as seen in Robert Olsson's testing.
Dipankar Sarma [Mon, 23 Aug 2004 05:58:16 +0000 (22:58 -0700)]
[PATCH] rcu: introduce call_rcu_bh()
Introduces call_rcu_bh() to be used when critical sections are mostly in
softirq context.
This patch introduces a new api - call_rcu_bh(). This is to be used for RCU
callbacks for whom the critical sections are mostly in softirq context. These
callbacks consider completion of a softirq handler to be a quiescent state.
So, in order to make reader critical sections safe in process context,
rcu_read_lock_bh() and rcu_read_unlock_bh() must be used. Use of softirq
handler completion as a quiescent state speeds up RCU grace periods and
prevents too many callbacks getting queued up in softirq-heavy workloads like
network stack.
Dipankar Sarma [Mon, 23 Aug 2004 05:57:53 +0000 (22:57 -0700)]
[PATCH] rcu: clean up code
Avoids per_cpu calculations and also prepares for call_rcu_bh().
At OLS, Rusty had suggested getting rid of many per_cpu() calculations in RCU
code and making the code simpler. I had already done that for the rcu-softirq
patch earlier, so I am splitting that into two patch. This first patch cleans
up the macros and uses pointers to the rcu per-cpu data directly to manipulate
the callback queues. This is useful for the call-rcu-bh patch (to follow)
which introduces a new RCU mechanism - call_rcu_bh(). Both generic and
softirq rcu can then use the same code, they work different global and percpu
data.
Dipankar Sarma [Mon, 23 Aug 2004 05:57:42 +0000 (22:57 -0700)]
[PATCH] RCU: low latency rcu
This patch makes RCU callbacks friendly to scheduler. It helps low latency
by limiting the number of callbacks invoked per tasklet handler. Since we
cannot schedule during a single softirq handler, this reduces size of
non-preemptible section significantly, specially under heavy RCU updates.
The limiting is done through a kernel parameter rcupdate.maxbatch which is
the maximum number of RCU callbacks to invoke during a single tasklet
handler.
Dipankar Sarma [Mon, 23 Aug 2004 05:57:30 +0000 (22:57 -0700)]
[PATCH] RCU - cpu offline fix
This fixes the RCU cpu offline code which was broken by singly-linked RCU
changes. Nathan pointed out the problems and submitted a patch for this.
This is an optimal fix - no need to iterate through the list of callbacks,
just use the tail pointers and attach the list from the dead cpu.
Dipankar Sarma [Mon, 23 Aug 2004 05:57:19 +0000 (22:57 -0700)]
[PATCH] RCU - cpu-offline-cleanup
There is a series of patches in my tree and these 3 are the first ones that
should probably be merged down the road. Descriptions are on top of the
patches. Please include them in -mm.
A lot of RCU code will be cleaned up later in order to support
call_rcu_bh(), the separate RCU interface that considers softirq handler
completion a quiescent state.
This patch:
Minor cleanup of the hotplug code to remove #ifdef in cpu event notifier
handler. If CONFIG_HOTPLUG_CPU is not defined, CPU_DEAD case will be
optimized off.
vma_prio_tree_insert() relies on the fact, that vma was
vma_prio_tree_init()'ed.
Content of vma->shared should be considered undefined, until this vma is
inserted into i_mmap/i_mmap_nonlinear. It's better to do proper
initialization in vma_prio_tree_add/insert.
Matt Mackall [Mon, 23 Aug 2004 05:55:57 +0000 (22:55 -0700)]
[PATCH] move duplicate BUG and WARN_ON bits to asm-generic
This moves duplicate BUG, PAGE_BUG, BUG_ON, and WARN_ON code to asm-generic
and makes them slightly more consistent. This cleanup is also preparatory
work for making BUG and WARN verbosity configurable.
Signed-off-by: Matt Mackall <mpm@selenic.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Greg Howard [Mon, 23 Aug 2004 05:55:46 +0000 (22:55 -0700)]
[PATCH] Altix system controller communication driver
drivers/char/Kconfig
Make a config option for the SGI Altix system controller
communication driver.
drivers/char/Makefile
Add an object file target for the SGI Altix system controller
communication driver.
drivers/char/snsc.c
This file implements a driver that allows an application to
communicate with the SGI Altix system controller network. Most of
the heavy lifting is done in SAL in order to allow Linux run-time
applications to share the system controller link(s) with SAL
run-time services.
drivers/char/snsc.h
Macros and data types for the Altix system controller driver
(drivers/char/snsc.c).
drivers/serial/sn_console.c
Modify the SGI Altix console driver to share an interupt with the
system controller communication driver.
include/asm-ia64/sn/sn_sal.h
Provide an interface to the SAL runtime services that allow the
kernel or user applications to send/receive arbitary system
controller data.
Signed-off-by: Greg Howard <ghoward@sgi.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Jan Blunck [Mon, 23 Aug 2004 05:54:59 +0000 (22:54 -0700)]
[PATCH] ext2_readdir() filp->f_pos fix
If the whole directory is read, ext2_readdir() sets the f_pos to a multiple
of the page size (because of the conditions of the outer for loop). This
sets the wrong f_pos for directory inodes on ext2 partitions with a block
size differing from the page size.
Signed-off-by: Jan Blunck <j.blunck@tu-harburg.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Jesper Juhl [Mon, 23 Aug 2004 05:54:48 +0000 (22:54 -0700)]
[PATCH] fix inline related gcc 3.4 build failures in drivers/net/wan/dscc4.c
drivers/net/wan/dscc4.c: In function `dscc4_found1':
drivers/net/wan/dscc4.c:369: sorry, unimplemented: inlining failed in call to 'dscc4_set_quartz': function body not available
drivers/net/wan/dscc4.c:898: sorry, unimplemented: called from here
Jesper Juhl [Mon, 23 Aug 2004 05:54:36 +0000 (22:54 -0700)]
[PATCH] inlining errors in drivers/scsi/aic7xxx/aic79xx_osm.c
This patch fixes the following build error (in 2.6.8-rc2-mm1) when using
gcc 3.4.0
drivers/scsi/aic7xxx/aic79xx_osm.c: In function `ahd_linux_dv_transition':
drivers/scsi/aic7xxx/aic79xx_osm.c:522: sorry, unimplemented: inlining failed in call to 'ahd_linux_dv_fallback': function body not available
drivers/scsi/aic7xxx/aic79xx_osm.c:3070: sorry, unimplemented: called from here
drivers/scsi/aic7xxx/aic79xx_osm.c:522: sorry, unimplemented: inlining failed in call to 'ahd_linux_dv_fallback': function body not available
drivers/scsi/aic7xxx/aic79xx_osm.c:3093: sorry, unimplemented: called from here
drivers/scsi/aic7xxx/aic79xx_osm.c:522: sorry, unimplemented: inlining failed in call to 'ahd_linux_dv_fallback': function body not available
drivers/scsi/aic7xxx/aic79xx_osm.c:3144: sorry, unimplemented: called from here
drivers/scsi/aic7xxx/aic79xx_osm.c:522: sorry, unimplemented: inlining failed in call to 'ahd_linux_dv_fallback': function body not available
drivers/scsi/aic7xxx/aic79xx_osm.c:3257: sorry, unimplemented: called from here
drivers/scsi/aic7xxx/aic79xx_osm.c:522: sorry, unimplemented: inlining failed in call to 'ahd_linux_dv_fallback': function body not available
drivers/scsi/aic7xxx/aic79xx_osm.c:3288: sorry, unimplemented: called from here
drivers/scsi/aic7xxx/aic79xx_osm.c:522: sorry, unimplemented: inlining failed in call to 'ahd_linux_dv_fallback': function body not available
drivers/scsi/aic7xxx/aic79xx_osm.c:3317: sorry, unimplemented: called from here
It first removes a duplicate forward declaration of ahd_linux_dv_fallback
and then moves the function before its first use so inlining can succeed.
Adrian Bunk [Mon, 23 Aug 2004 05:54:25 +0000 (22:54 -0700)]
[PATCH] radio-maestro.c: gcc-3.5 fixes
CC drivers/media/radio/radio-maestro.o
drivers/media/radio/radio-maestro.c: In function `maestro_radio_init':
drivers/media/radio/radio-maestro.c:273: sorry, unimplemented: inlining failed in call to 'radio_install': function body not available
drivers/media/radio/radio-maestro.c:291: sorry, unimplemented: called from here
drivers/media/radio/radio-maestro.c:273: sorry, unimplemented: inlining failed in call to 'radio_install': function body not available
drivers/media/radio/radio-maestro.c:295: sorry, unimplemented: called from here
make[3]: *** [drivers/media/radio/radio-maestro.o] Error 1
Signed-off-by: Adrian Bunk <bunk@fs.tum.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Adrian Bunk [Mon, 23 Aug 2004 05:54:13 +0000 (22:54 -0700)]
[PATCH] mxser.c: gcc-3.5 fixes
CC drivers/char/mxser.o
drivers/char/mxser.c: In function `mxser_interrupt':
drivers/char/mxser.c:352: sorry, unimplemented: inlining failed in call to 'mxser_receive_chars': function body not available
drivers/char/mxser.c:1347: sorry, unimplemented: called from here
drivers/char/mxser.c:354: sorry, unimplemented: inlining failed in call to 'mxser_check_modem_status': function body not available
drivers/char/mxser.c:1350: sorry, unimplemented: called from here
drivers/char/mxser.c:353: sorry, unimplemented: inlining failed in call to 'mxser_transmit_chars': function body not available
drivers/char/mxser.c:1355: sorry, unimplemented: called from here
make[2]: *** [drivers/char/mxser.o] Error 1
Signed-off-by: Adrian Bunk <bunk@fs.tum.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Adrian Bunk [Mon, 23 Aug 2004 05:54:02 +0000 (22:54 -0700)]
[PATCH] istallion: gcc-3.5 fixes
CC drivers/char/istallion.o
drivers/char/istallion.c: In function `stli_init':
drivers/char/istallion.c:4603: sorry, unimplemented: inlining failed in call to 'stli_getbrdnr': function not considered for inlining
drivers/char/istallion.c:4577: sorry, unimplemented: called from here
drivers/char/istallion.c: At top level:
drivers/char/istallion.c:422: warning: 'istallion_pci_tbl' defined but not used
make[2]: *** [drivers/char/istallion.o] Error 1
Signed-off-by: Adrian Bunk <bunk@fs.tum.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Antonino Daplas [Mon, 23 Aug 2004 05:53:17 +0000 (22:53 -0700)]
[PATCH] epson1355fb: salvage epson1355 code from James' tree
This patch was submitted by James Hoover < ch@hpl.hp.com> to James a long
time ago (2.5 development) which ports the epson driver to 2.6. Took the
code from James tree to be hopefully included in the mm tree so it can get
more testing.
Antonino Daplas [Mon, 23 Aug 2004 05:53:05 +0000 (22:53 -0700)]
[PATCH] rivafb: directcolor mode and miscellaneous fixes
Although the rivafb advertises its capability as DirectColor, the hardware
is actually set in Truecolor (CLUT cannot be altered). This mismatch
occasionally produces wrong colors, such as wrong logo colors at 32bpp and
gamma utilities (such as xgamma) does not work at all.
Changes:
1. Fixes the above problems by setting the hardware to accept changing
of the CLUT.
2. Fixes color problems for NV_ARCH_03 (Riva128)
3. Build a private modelist from the EDID (for use by fbcon)
4. Mark several functions/data as __devinit/__initdata
Antonino Daplas [Mon, 23 Aug 2004 05:52:54 +0000 (22:52 -0700)]
[PATCH] fbdev: use 8-bit DAC for capable hardware
The patch adds the ability for vesafb to switch the DAC from 6-bit to 8-bit
at kernel boot. Besides fixing the failure to draw the 224-color logo, an
8-bit DAC will also provide a wider color range for user applications.
Antonino Daplas [Mon, 23 Aug 2004 05:52:43 +0000 (22:52 -0700)]
[PATCH] fbdev: support for bold attribute for monochrome framebuffers
This patch adds support for the bold attribute for monochrome framebuffers.
This fixes a regression from 2.4 where bold, underline and reverse
attributes are supported.
Antonino Daplas [Mon, 23 Aug 2004 05:52:19 +0000 (22:52 -0700)]
[PATCH] Video Mode Handling - Reduce memory footprint of fbdev
This patch is entirely optional. Its only advantage is reduction of kernel
size by ~5-6K.
a. Mark modedb as __init.
b. Add CONFIG_FB_MODE_HELPERS. Unselecting this will uninclude the code
for Generalized Timing Formula and the EDID parser on kernel compilation.
These are used only by radeonfb, rivafb and i810fb.
Antonino Daplas [Mon, 23 Aug 2004 05:52:08 +0000 (22:52 -0700)]
[PATCH] Video Mode Handling - Delete entries from mode list
This is optional but applying it should enhance fbdev functionality.
The patch allows removal of entries to the mode list. This is done by setting
the var->activate field to FB_ACTIVATE_INV_MODE. Only modes that are not in
use by any of the console or by the current var will be deleted.
Antonino Daplas [Mon, 23 Aug 2004 05:51:45 +0000 (22:51 -0700)]
[PATCH] Video Mode Handling - Linked list of video modes
The patch adds support for a mode database in a linked list form.
Included in the patch are exportable functions that will:
a. convert struct fb_videomode to struct fb_var_screeninfo and vice versa
b. search the mode list for matching or best-fit modes
c. add/delete entries to the database
d. convert a mode array to a mode list
e. destroy the entire list
d. compare 2 modes
Guido Guenther [Mon, 23 Aug 2004 05:51:12 +0000 (22:51 -0700)]
[PATCH] rivafb: kill riva_chip_info and riva_chips
Kill riva_chips_info and riva_chips and replace the NV_ARCH_ determination
with a less error prone one. We better use the driver_data for something
more interesting later.
From: "Antonino A. Daplas" <adaplas@hotpop.com>
1. modified patch so it's in -p1 form
2. killed compile warning when CONFIG_FB_RIVA_I2C is not set
3. changed U032 to u32 in riva_get_arch()
Antonino Daplas [Mon, 23 Aug 2004 05:51:00 +0000 (22:51 -0700)]
[PATCH] fbdev: find correct logo for directcolor < 24bpp
Current algorithm does not choose correct logo type for directcolor < 24
bpp. It chooses logo_224, but this is too deep for bpp < 24. This should
fix the problem.
Antonino Daplas [Mon, 23 Aug 2004 05:50:49 +0000 (22:50 -0700)]
[PATCH] i810fb fixes
1. Fixed cursor corruption if acceleration is enabled
2. Round up fields in var instead of rounding down
3. Set capabilities flags
4. Added myself to the MAINTAINERS file for i810fb
5. Make i810fb depend on X86 but not X86_64
6. Fixed typo in i810_init_monspecs(). Reported by Manuel Lauss
<slauss@resi.at>.
Antonino Daplas [Mon, 23 Aug 2004 05:50:25 +0000 (22:50 -0700)]
[PATCH] fbdev: ATTN: Maintainers - Set correct hardware capabilities
With David Eger's patch for advertising hardware capabilities to fbcon,
only a few drivers so far have been converted to do just that. As a
result, scrolling speed of some drivers will not be optimal
(SCROLL_REDRAW). The patch adds the correct flags for all drivers (except
for matroxfb -leave this to Petr-, and a few drivers that are not ported
yet to 2.6).
*Majority of changes is FBINFO_FLAG_DEFAULT -> FBINFO_DEFAULT
Antonino Daplas [Mon, 23 Aug 2004 05:50:12 +0000 (22:50 -0700)]
[PATCH] fbdev: set color fields correctly
Although the depth can be correctly inferred from bits_per_pixel (if
bits_per_pixel == 1), for the sake of consistency, drivers should still set
the color fields correctly. True even if the first patch is not applied.
(I've combined everything in a single diff since there is only 1 logical
change)
Antonino Daplas [Mon, 23 Aug 2004 05:50:00 +0000 (22:50 -0700)]
[PATCH] fbcon: ifferentiate bits_per_pixel from color depth
1. If you remember this thread (HP300 support checked in), one concern
was how to support framebuffers with bpp == 8 but color depth < 8
(chunky layout). I suggested to use the fields in var->{red|green|blue}
to differentiate between bits_per_pixel and depth. Included is a patch
that does that.
(The above assumes background/foreground of 0/1. If hardware needs a
different value, such as 0 - black, 0xff - white, just indicate
TRUECOLOR or DIRECTCOLOR and set info->pseudopalette correctly in
xxxfb_setcolreg().)
The patch will break the following drivers when in monochrome since
they do not set the proper color bitfields. I've included a fix in
patch #2.
2. Besides the change above, support for the inverse and underline
attribute is added in monochrome mode. One should get text which are
underlined/reversed if the corresponding attribute is set.
3. Because vt.c uses a 16-color palette, use fbcon_default_cmap if
framebuffer can do less than 16 colors. In 4 colors, display will be
grayscaled. In 8 colors, display should have the same colors as a
16-color console but will lack brightness/ intensity.
4. Fix monochrome logo drawing.
5. Reduce code of fbcon_putc so it just calls fbcon_putcs.
Antonino Daplas [Mon, 23 Aug 2004 05:49:47 +0000 (22:49 -0700)]
[PATCH] fbcon: EDD-based blacklisting
1. Created a database of broken displays and their associated fixes.
Original patch from Brian S. Julin <bri@tull.umassp.edu>. Only the
monitor manufacturer and model is checked, perhaps we can also check
for the serial number?
2. Added an all_null check in edid_checksum since the checksum will also be
zero if the entire block is zeroed.
Nicolas Boichat [Mon, 23 Aug 2004 05:49:36 +0000 (22:49 -0700)]
[PATCH] Rivafb I2C fixes
The I2C busses opened by rivafb were deleted immediately after reading the
EDID, but they should be kept open, so user-space applications can use them.
They are now deleted when the driver is unloaded.
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
David Eger [Mon, 23 Aug 2004 05:49:24 +0000 (22:49 -0700)]
[PATCH] radeonfb: cleanup and little fixes
Very similar to Francois Romieu's fixes for cirrusfb, here we:
* Provide meaningful error values from radeonfb_pci_register()
* Fix unbalanced pci_enable_device()
* Fix unbalanced fb_alloc_cmap()
* Fix a failure-case bug where we accidentally memset_io(0, 0, size);
* Use pci_request_regions() instead of request_mem_region()
Signed-off-by: David Eger <eger@havoc.gtf.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Dave Hansen [Mon, 23 Aug 2004 05:49:13 +0000 (22:49 -0700)]
[PATCH] break out zone free list initialization
The following patch removes the individual free area initialization from
free_area_init_core(), and puts it in a new function
zone_init_free_lists(). It also creates pages_to_bitmap_size(), which is
then used in zone_init_free_lists() as well as several times in my free
area bitmap resizing patch.
First of all, I think it looks nicer this way, but it's also necessary to
have this if you want to initialize a zone after system boot, like if a
NUMA node was hot-added. In any case, it should be functionally equivalent
to the old code.
Compiles and boots on x86. I've been running with this for a few weeks,
and haven't seen any problems with it yet.
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Nick Piggin [Mon, 23 Aug 2004 05:49:02 +0000 (22:49 -0700)]
[PATCH] make shrinker_sem an rwsem
Use an rwsem to protect the shrinker list instead of a regular
semaphore. Modifications to the list are now done under the write lock,
shrink_slab takes the read lock, and access to shrinker->nr becomes racy
(which is no different to how the page lru scanner is implemented). The
shrinker functions become concurrent.
Previously, having the slab scanner get preempted or scheduling while
holding the semaphore would cause other tasks to skip putting pressure on
the slab.
Also, make shrink_icache_memory return -1 if it can't do anything in order
to hold pressure on this cache and prevent useless looping in shrink_slab.
Signed-off-by: Nick Piggin <nickpiggin@yahoo.com.au> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Mark Broadbent [Mon, 23 Aug 2004 05:48:50 +0000 (22:48 -0700)]
[PATCH] IO-APIC debug message reduction
The APIC and IO-APIC code is very verbose on startup especially on SMP
machines. This patch allows the verbosity of the APIC code to be controlled
through the boot-time option apic= using three levels: quiet, verbose and
debug. The default level is quiet.
Signed-off-by: Mark Broadbent <markb@wetlettuce.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Dimitri Sivanich [Mon, 23 Aug 2004 05:48:27 +0000 (22:48 -0700)]
[PATCH] slab: locking optimization for cache_reap
Here is another cache_reap optimization that reduces latency when applied
after the 'Move cache_reap out of timer context' patch I submitted on 7/14
(for inclusion in -mm next week).
Bálint Márton [Mon, 23 Aug 2004 05:48:16 +0000 (22:48 -0700)]
[PATCH] get_random_bytes() returns the same on every boot
At boot time, get_random_bytes always returns the same random data, as if
there were a constant random seed. For example, if I use the kernel level
ip autoconfiguration with dhcp, the kernel will create a dhcp request
packet with always the same transaction ID. (If you have more than one
computers, and they are booting at the same time, then this is a big
problem)
That happens, because only the primary entropy pool is initialized with the
system time, in function rand_initialize. The secondary pool is only
cleared. In this early stage of booting, there is usually no user
interaction, or usable disk interrupts, so the kernel can't add any real
random bytes to the primary pool. And altough the system time is in the
primary pool, the kernel does not consider it real random data, so you
can't read from the primary pool, before at least a part of it will be
filled with some real randomness (interrupt timing). Therefore all random
data will come from the secondary pool, and the kernel cannot reseed the
secondary pool, because there is no real randomness in the primary one.
The solution is simple: Initialize not just the primary, but also the
secondary pool with the system time.
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Samuel Thibault [Mon, 23 Aug 2004 05:48:04 +0000 (22:48 -0700)]
[PATCH] Subject: cdrom.c get_last_written fixup
There's something wrong in cdrom.c: cdrom_get_last_written() for instance
calls cdrom_get_disc_info() and cdrom_get_track_info() to get information
about tracks, but these functions don't ensure that all the
track_information or disc_information structure is filled:
/* (buflen was first set to 8 to get track_information_length field) */
if ((ret = cdo->generic_packet(cdi, &cgc)))
return ret;
The second test ensures that at least we won't overflow the structure, but
nothing ensures that all the structure will be filled.
And indeed, we have a drive here that won't fill it all: the returned
track_information_length field will be *less than*
sizeof(track_information) - sizeof(ti->track_information_length), so that
cdrom_get_last_written() reads values that weren't filled in! As a result,
we are sometimes unable to read some parts of CDROMs, depending on the
uninitialized state of the structure...
Here is a patch that adds filling checks: cdrom_get_disc_info() and
cdrom_get_track_info() return the actual filled length, and it's up to the
caller to check that this is enough for him to get the values it wants.
Note: adding something like a
#define spanof(TYPE, MEMBER) ((size_t) ((&((TYPE *)0)->MEMBER)+1))
definition just near that of offsetof() in include/linux/stddef.h would
make it more pretty, but still it won't help for bitfields :/
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Arthur Othieno [Mon, 23 Aug 2004 05:47:53 +0000 (22:47 -0700)]
[PATCH] s390: Use include/asm-generic/dma-mapping-broken.h
ChangeSet 1.1371.413.23 [1] introduced the file
include/asm-generic/dma-mapping-broken.h for architectures that don't
support the new DMA API. I don't know if this is the case with s390,
however, ChangeSet 1.1371.445.6 [2] introduced a set of changes that
duplicate those in include/asm-generic/dma-mapping-broken.h.
This patch squishes that duplication by simply including
include/asm-generic/dma-mapping-broken.h in
include/asm-s390/dma-mapping.h.
Signed-off-by: Arthur Othieno <a.othieno@bluewin.ch> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Roland McGrath [Mon, 23 Aug 2004 05:47:28 +0000 (22:47 -0700)]
[PATCH] Fix x86-64 singlestep through sigreturn system call
This patch just directly clones Davide Libenzi's i386 code for x86-64 in
both 64-bit and 32-bit cases. With this, the behavior of single-stepping
all system calls is consistent.
The syscall exit tracing caused by TIF_SINGLESTEP is superfluous in the
case of sysret returns, but harmlessly so (since continuing afterward with
PTRACE_CONT will have cleared TF as well as TIF_SINGLESTEP). I figured
that little bit of extra processing in the single-step case was better than
adding code to ignore the flag in the sysret case.
Signed-off-by: Roland McGrath <roland@redhat.com> Cc: <ak@muc.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This issue was discussed on lkml and linux-ia64. The patch introduces
"getnstimeofday" and removes all the code scaling gettimeofday to
nanoseoncs. It makes it possible for the posix-timer functions to return
higher accuracy.
Signed-off-by: Christoph Lameter <clameter@sgi.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Dimitri Sivanich [Mon, 23 Aug 2004 05:47:04 +0000 (22:47 -0700)]
[PATCH] Move cache_reap out of timer context
I'm submitting two patches associated with moving cache_reap functionality
out of timer context. Note that these patches do not make any further
optimizations to cache_reap at this time.
The first patch adds a function similiar to schedule_delayed_work to allow
work to be scheduled on another cpu.
The second patch makes use of schedule_delayed_work_on to schedule
cache_reap to run from keventd.
Various people have reported deadlocks and it has aways seemed a bit risky
to try to sync the filesystems at this stage anyway.
"I have seen panic failing two times lately on an SMP system. The box
panic'ed but was running happily on the other cpus. The culprit of this
failure is the fact, that these panics have been caused by a block device
or a filesystem (e.g. using errors=panic). In these cases the likelihood
of a failure/hang of sys_sync() is high. This is exactly what happened in
both cases I have seen. Meanwhile the other cpus are happily continuing
destroying data as the kernel has a severe problem but its not aware of
that as smp_send_stop happens after sys_sync."
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Hannes Reinecke [Mon, 23 Aug 2004 05:46:30 +0000 (22:46 -0700)]
[PATCH] Enable all events for initramfs
Currently most driver events are not sent out when using initramfs as
driver_init() (which triggers the events) is called before init_workqueues.
This patch rearranges the init calls so that the hotplug event queue is
enabled prior to calling driver_init(), hence we're getting all hotplug
events again.
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Andrew Morton [Mon, 23 Aug 2004 05:46:19 +0000 (22:46 -0700)]
[PATCH] send_IPI_mask_bitmask() build fix
With gcc-3.4.1:
arch/i386/kernel/smp.c: In function `flush_tlb_others':
arch/i386/kernel/smp.c:161: sorry, unimplemented: inlining failed in call
to 'send_IPI_mask_bitmask': function not considered for inlining
arch/i386/kernel/smp.c:9: sorry, unimplemented: called from here
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Jose R. Santos [Mon, 23 Aug 2004 05:46:07 +0000 (22:46 -0700)]
[PATCH] Make i/dhash_entries cmdline work as it use to.
I was looking at the recent for >MAX_ORDER hash tables but it seems that
the patch limits the number of entries to what it thinks are good values
and the i/dhash_entries cmdline options can not exceed this.
This seems to limit the usability of the patch on systems were larger
allocations that the ones the kernel calculates are desired.
- Make ihash_entries and dhash_entries cmdline option behave like it use to.
- Remove MAX_SYS_HASH_TABLE_ORDER. Limit the max size to 1/16 the total
number of pages.
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
[PATCH] split generic_file_aio_write into buffered and direct I/O parts
If the generic code falls back to buffered I/O on a hole XFS needs to
relock, so we need to have separate functions to call unless we want to
duplicate everything. The XFS patch still needs some cleaning up, but I'll
try to get it in before 2.6.8.
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
gcc-3.4.1 errors out in 2.6.8-rc1-mm1 at arch/i386/kernel/smp.c:
arch/i386/kernel/smp.c: In function `flush_tlb_others':
arch/i386/kernel/smp.c:161: sorry, unimplemented: inlining failed in call to 'send_IPI_mask_bitmask': function not considered for inlining
arch/i386/kernel/smp.c:9: sorry, unimplemented: called from here
make[1]: *** [arch/i386/kernel/smp.o] Error 1
make: *** [arch/i386/kernel] Error 2
The <mach_ipi.h> inlines depend on functions defined further down in smp.c.
Moving the #include eliminates the problem.
Signed-off-by: Mikael Pettersson <mikpe@csd.uu.se> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Arnd Bergmann [Mon, 23 Aug 2004 05:45:33 +0000 (22:45 -0700)]
[PATCH] clean up __always_inline__ usage
I find it somewhat annoying that the preprocessor expands every "inline" to
"__inline__ __attribute__((always_inline)) __attribute__((always_inline))"
in the current code.
Fix that up.
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Andi Kleen [Mon, 23 Aug 2004 05:43:38 +0000 (22:43 -0700)]
[PATCH] gcc-3.5: fixmap.h fix
Not strictly needed, since we're forcing `inline' to always_inline, but it's
good for documentation purposes - This function needs the always_inline
otherwise you get a link error when the compile time test is not optimized
away.
Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Manfred Spraul [Mon, 23 Aug 2004 05:41:21 +0000 (22:41 -0700)]
[PATCH] cleanup of ipc/msg.c
Attached is a cleanup of the main loops in sys_msgrcv and sys_msgsnd, based on
ipc_lock_by_ptr(). Most backward gotos are gone, instead normal "for(;;)"
loops until a suitable message is found.
Description:
- General cleanup of sys_msgrcv and sys_msgsnd: the function were too
convoluted.
- Enable lockless receive, update comments.
- Use ipc_getref for sys_msgsnd(), it's better than rechecking that the
msqid is still valid.
Manfred Spraul [Mon, 23 Aug 2004 05:41:02 +0000 (22:41 -0700)]
[PATCH] ipc: enforce SEMVMX limit for undo
Independent from the other patches:
undo operations should not result in out of range semaphore values. The test
for newval > SEMVMX is missing. The attached patch adds the test and a
comment.
Manfred Spraul [Mon, 23 Aug 2004 05:40:37 +0000 (22:40 -0700)]
[PATCH] ipc: Add refcount to ipc_rcu_alloc
The lifetime of the ipc objects (sem array, msg queue, shm mapping) is
controlled by kern_ipc_perms->lock - a spinlock. There is no simple way to
reacquire this spinlock after it was dropped to
schedule()/kmalloc/copy_{to,from}_user/whatever.
The attached patch adds a reference count as a preparation to get rid of
sem_revalidate().
Davide Libenzi [Mon, 23 Aug 2004 05:40:02 +0000 (22:40 -0700)]
[PATCH] Don't use SYSGOOD for ptrace singlestep
The ptrace single step mode should not use the SYSGOOD bit and should not
report SIGTRAP|0x80 to the ptrace parent. The following patch add an
explicit check and to not add 0x80 in this is a singlestep trap.
projects / linux / log