Jens Axboe [Fri, 17 May 2002 17:02:37 +0000 (10:02 -0700)]
[PATCH] fix scsi oops on failed sg table allocation
This patch fixes the deliberate BUG_ON() on failed sgtable allocations.
I left that in because I was too lazy to fix it at the time...
Basically make scsi_init_io() return 0 on failure (like before) but this
time allow us to recover. scsi_init_io() will end_request on a fatal
condition. So now just mark the device/host as starved if needed, and
leave the request at the front of the queue for next service.
This driver handles up to 16 PCI based NVRAM cards
from MicroMemory.
Each card appears like a block device, and can be partitioned
using any standard partitioning tool. Upto 15 partitions are
supported.
This driver needs its own major device number and so allocates
one using register_blkdev.
Martin Dalecki [Fri, 17 May 2002 16:48:40 +0000 (09:48 -0700)]
[PATCH] 2.5.15 IDE 63
- Propagate the queue handling changes to pmac as well.
- Move set_transfer to ide-taskfile.c this is the only place where it's used
and it can be made static there. Same applies to ide_ata66_check().
- Move ide_auto_reduce_xfer to ide.c.
- Make ide_cmd() local to the only place where it's used. Rename it to
drive_cmd(). Don't pass drive_cmd_intr() as parameter.
- Remove ide_next command completion type. Nobody is using it.
- Move ide_do_drive_cmd to ide-taskfile. It's used there and in sub-drivers.
Not in ide.c. The usage inside the device type drivers is entirely bogus
inconsistent and so on...
- Kill bogus IRQ masking code. The kernel is supposed to handle this properly.
We should not try to work against possible bugs in the overall irq handling
code. Wow this is increasing the systems overall responsibility by a
significant margin.
- Remove disfunctional pdcadma code. It is only misleading to the user.
Martin Dalecki [Fri, 17 May 2002 16:47:35 +0000 (09:47 -0700)]
[PATCH] 2.5.15 IDE 62a
- Streamline device detection reporting to always use ->slot_name.
- Apply 64 bit sector size fixes to the overall code.
- Push ->handler down to the struct ata_channel.
- Introduce channel group based locking instead of a single global lock for all
operations. There are still some places where we have preserved the ide_lock.
We can't lock for queues during device probe and we protect global data
structures during device registration and unregistration in ide.c with it.
- Start replacement of serialized access to the registers of
channels which share them with proper host chip driver specific locking.
This affects the following host chip drivers:
cmd640.c, rz1000, ... ?
Seems some are setting the serialize flag just in case. So better let's do it
gradually over time.
Well, I still have to think whatever we really need to put channels sharing
an IRQ line in the same locking group.
From now on the sick concept of a hw group is gone now. We have full blown
per channel request queues! Hopefully I will be able soon to get my hands on
a dual Athlon machine to check how this all behaves on a multi SMP machine.
- Move the whole SUPPORT_VLB_SYNC stuff to the only place where it is used: the
pdc4030 host chip driver. Eliminate it from the global driver part.
- Eliminate pseudo portability macros from pdc4030. This is a host chip firmly
based on VLB.
Martin Dalecki [Fri, 17 May 2002 16:46:39 +0000 (09:46 -0700)]
[PATCH] 2.5.15 IDE 61
- Fix typo in pdc202xx driver.
- Fix locking order in ioctl.
- Fix wrong time_after usage introduced in 60. Maybe the fact I always get is
wrong is related to the fact that I'm using the mouse with the left hand!?
- Apply arch-clean-2 by Bartlomiej Zolnierkiewicz.
- Don't disable interrupts during ide_wait_stat(). I see no reason too.
- Push flags down from hwgroup to the ata_chaannel structure.
- Apply small fixes from Franz Sirl to make AEC6280 working properly again.
Robert Love [Fri, 17 May 2002 16:42:53 +0000 (09:42 -0700)]
[PATCH] clean up maximum priorities
This patch further cleans up and separates the code in an effort to
allow setting (a) a larger maximum real-time priority than default and
(b) a maximum kernel RT priority that is separate than the maximum
priority exported to user-space.
- Commented out the usb-ohci driver. This is part of the migration away from
this driver, to the ohci-hcd driver.
- Prevented the two UHCI_HCD drivers from both being compiled into the kernel
at the same time.
Georg Acher [Fri, 17 May 2002 02:48:54 +0000 (19:48 -0700)]
[PATCH] USB-UHCI-HCD
After maturing for more than a month, I decided that it's enough...
So here's the patch for the HCD-version of usb-uhci, I called it
usb-uhci-hcd. For me, the usual devices work (TM).
Since the internals haven't changed much, I don't expect much difference to
usb-uhci in functionality and performance.
There is one major improvement: I've added a (preliminary) watchdog, that
regularly checks whether UHCI interrupts are coming through. If they are
"missing", ie. the HC halted without saying so, the HC is "re-animated" by a
real and clean restart, which is (internally) equivalent to a module-reload.
This is especially for VIA-chips which get comatose quite easily by babble
or other incorrect transfers.
The side effect is, of course, disconnects for all connected devices, but
they re-appear after a few seconds and were dead before anyway. So keyboard
and mouse work again, which is IMO a _very_ useful thing :-)
Another point: The watchdog (currently with moderate 8 interrupts/s) detects
IRQ-problems, so the misleading "device doesn't accept new device"-message
is replaced by an immediate error.
More comments and the separation into multiple files (I've taken ohci-hcd as
an example) should make the code more concise...
A few things are still on the todo-list and will come later:
- A few watchdog modifications (fewer interrupts, better diagnostics)
- Support for module "tune"-parameters for breadth/depth search, debug etc.
- interval support for ISO
- More SMP-tests
- maybe changes for reference counting when it is clear what survives :-)
Johannes Erdfelt [Thu, 16 May 2002 04:50:34 +0000 (21:50 -0700)]
[PATCH] 2.4.19-pre8 uhci.c incorrect bit operations
This fixes up a couple of problems I came across while working on
uhci-hcd. There are a couple of places where shifts are used where they
shouldn't be and others where should be.
This cleans up a couple of cases and tidys it up.
The patch is relative to 2.4.19-pre8 and my other patches, but it's
alright to wait for 2.4.20. It should also be applied to 2.5.
Johannes Erdfelt [Thu, 16 May 2002 04:09:10 +0000 (21:09 -0700)]
[PATCH] uhci-hcd for 2.5.15
So I finally hunkered down and got uhci-hcd working. I was surprised how
easy it was to make the modifications for hcd.c.
This patch has received a moderate amount of testing so far. I've played
with various devices and haven't had any problems. I won't claim it's
bug free yet and I'll continue doing more testing.
The patch includes a small change to hcd.c to not call free_config if
the HCD doesn't implement it.
There are some other messages that get printed such as:
hcd.c: usb_hcd_pci_remove 00:10.0, count != 1
but it appears from the code that this is just a soft warning that all
of the references to the bus aren't freed yet. This isn't a bug.
Differences from usb-uhci/usb-uhci-hcd:
- Cleaner code. uhci-hcd is based off of uhci, so it maintains the same
look and feel as well as readability.
- Faster. The tests I've run so far show that uhci-hcd is faster in
every case than usb-uhci-hcd
- It does not have the watchdog type feature for VIA chipsets. It's
something that is definately possible to implement, but I'd like to
find out what Windows does first.
Differences from uhci:
- Modified to use the hcd.c framework. This removed a significant amount
of code and nesessitated lots of little changes.
- Big endian support. I haven't been able to test it on a big endian
machine yet, but atleast 90+% of the work should be done. Once I get
my PowerPC working again, I'll test this and submit any appropriate
patches. This was the biggest functional change between uhci.c.
- No more urb->next processing. Completely ripped out.
- urb->interval support for Isochronous pipes.
- A couple of bug fixes for some problems I noticed while working on the
code. These will be submitted for uhci.c in a seperate email.
[PATCH] USB device reference counting api cleanup changes
This patch replaces the awkwardly named usb_inc_dev_use() and
usb_dec_dev_use() with usb_get_dev() and usb_put_dev() to match the
naming convention of the rest of the kernel's reference counted
structures. It also does away with the special case of usb_free_dev(),
and has usb_put_dev() be the same thing (through a #define, just like
usb_free_urb() works.)
Now when the last person calls usb_put_dev() or usb_free_dev() the
structure is cleaned up. This allows the different host controller
drivers to implement their logic differently if they want to (as they
do), and everyone can be happy and stop arguing about the "proper" way
to write their host controller drivers :)
Johannes Erdfelt [Mon, 13 May 2002 07:48:22 +0000 (00:48 -0700)]
[PATCH] USB device reference counting fix for uhci.c and usb core
Earlier in the 2.5 development cycle a patch was applied that changed
the reference counting behaviour for USB devices.
There are a couple of problems with the change:
- It made the USB code more complicated as a whole with the introduction
of an additional cleanup path for devices. Using the traditional method
of reference counting, cleanup is handled implictly
- It reduces functionality by requiring a callback for all references to
the device, but doesn't provide a method of providing callbacks for
references. It relies on the hardcoded device driver ->disconnect and
HCD ->deallocate method for callbacks
The traditional method of using reference counting supports as many
reference users as needed, without complicating it with mandatory
callbacks to cleanup references.
The change in 2.5 also only helps catch one subset of programming
problem in device drivers, the case where it decrements too many times.
That is of dubious debugging value.
So, this patch reverts the change and makes the reference counting
behave like it does in the rest of the kernel as well as how the USB
code does in 2.4.
This patch doesn't remove all of the superfluous code. Some drivers,
like usb-ohci, ohci-hcd and ehci-hcd have some code that is no longer
needed. I wanted to spend some more time with those drivers since the
changes weren't as trivial as uhci.c and usb-uhci.c.
I've tested with uhci and usb-ohci with no adverse effects.
Manfred Spraul [Mon, 13 May 2002 07:25:19 +0000 (00:25 -0700)]
[PATCH] usb-storage locking fixes
I found several SMP and UP locking errors in usb-storage, attached is a
patch:
Changes:
* srb->result is a bitfield, several << 1 were missing.
* add scsi_lock calls around midlayer calls, release the lock before
calling usb functions that might sleep.
* replace the queue semaphore with a queue spinlocks, queuecommand is
called from bh context.
Russell King [Mon, 13 May 2002 01:05:00 +0000 (02:05 +0100)]
2.5.14 updates - for the new memory management pfn() macros. Also,
we fix ARM720T support - this CPU has unified writethrough caches
only, so we can't use the Harvard cache operations when copying
pages. Also, we don't have to evict cache entries during copypage.
Johannes Erdfelt [Sat, 11 May 2002 14:16:49 +0000 (07:16 -0700)]
[PATCH] uhci.c FSBR timeout
There was a discussion a long time ago about how safe the bit operations
were as well as recently.
set_bit/clear_bit are not safe on x86 UP, nor are they safe on other
architectures. It's also unclear from the UHCI spec if the HC's are safe
with respect to atomic updates to the status field.
This patch ditches all of the uses of set_bit and clear_bit and changes
the algorithm that depended on it.
The FSBR timeout algorithm would reenable FSBR for transfers when they
started making progress again. So instead of trying for this best case,
we convert the transfer over to depth first from the standard breadth
first. To make sure the transfer doesn't hog all of the bandwidth, every
5th TD is left in breadth first mode. This will ensure other transfers
get some bandwidth.
It's not perfect, but I think it's a good compromise.
Note: td->info is read only by the HC, so we can touch it whenever we
want.
David Brownell [Sat, 11 May 2002 14:16:35 +0000 (07:16 -0700)]
[PATCH] -- hub/tt error recovery
This patch adds missing functionality to the transaction translator
support for USB 2.0 hubs:
- moves the 'struct usb_tt' definition to "hub.h" from <linux/usb.h>
- adds state to it as neeed for some control/bulk error recovery
- teaches the hub driver how to use that state (via keventd)
- adds a call letting HCDs trigger that recovery
David Brownell [Sat, 11 May 2002 14:16:19 +0000 (07:16 -0700)]
[PATCH] -- ehci misc FIXMEs
This addresses FIXME comments in the EHCI code, notably:
- telling the hub driver to clear up TT error state
(relies on the hub error recovery patch I just sent)
- using 64bit PCI DMA where appropriate
- handling BIOS handoff as neeed
Richard Gooch [Sat, 11 May 2002 04:06:34 +0000 (04:06 +0000)]
misc.c:
Do not put miscellaneous character devices in /dev/misc if they
specify their own directory (i.e. contain a '/' character)
util.c:
Copied and used macro for error messages from fs/devfs/base.c
base.c:
Removed 2.4.x compatibility code
Added BKL to <devfs_open> because drivers still need it
Paul Mackerras [Sun, 12 May 2002 08:06:30 +0000 (18:06 +1000)]
PPC32: This changeset updates several of the powermac-specific
drivers. Most of this is from 2.4. Almost all of this work was
done by Ben Herrenschmidt.
Jean Tourrilhes [Sat, 11 May 2002 00:49:24 +0000 (20:49 -0400)]
IrDA update 3/3:
<Following patch from Christoph Bartelmus, mangled by me>
o [CORRECT] replace the global LSAP cache with LSAP caches private
to each LAP.
Fix a bug where two simultaneous connections from two devices
using the same LSAPs would get mixed up.
Should also improve performance in similar cases.
Jean Tourrilhes [Sat, 11 May 2002 00:48:31 +0000 (20:48 -0400)]
IrDA update 2/3, set_bit updates:
<Following patch from Paul Mackerras>
o [CORRECT] Argument of set_bit and friends should be unsigned long
Should fix all compile warnings ;-)
projects / linux / log