]> git.hungrycats.org Git - linux/commit
HID: asus: fix missing hid_is_usb() check
authorJann Horn <jannh@google.com>
Fri, 3 Jul 2026 15:45:52 +0000 (17:45 +0200)
committerJiri Kosina <jkosina@suse.com>
Mon, 3 Aug 2026 18:42:07 +0000 (20:42 +0200)
commit02bf61dfb44f17ec187d1da1a82495951bbd12df
tree18175c7fe61bb472e03058687291077c42d887e2
parenta13cdb19fcb223ed41bdab3bab42b98dba87e90b
HID: asus: fix missing hid_is_usb() check

to_usb_interface() can only be used on a hid_device whose parent is really
USB; uhid can create devices that identify as being on BUS_USB, but don't
actually have a USB parent.
Fix the use of to_usb_interface() without a hid_is_usb() check.

I have verified that it is currently possible to trigger a kernel splat due
to this bug in an ASAN build, and that this commit fixes the issue.

Fixes: 00e005c952f7 ("hid-asus: check ROG Ally MCU version and warn")
Cc: stable@vger.kernel.org
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-asus.c