]> git.hungrycats.org Git - linux/commit
efi/libstub: Free correct pointer on failure
authorArd Biesheuvel <ardb@kernel.org>
Sun, 13 Oct 2024 13:19:04 +0000 (15:19 +0200)
committerArd Biesheuvel <ardb@kernel.org>
Fri, 15 Nov 2024 09:40:51 +0000 (10:40 +0100)
commit06d39d79cbd5a91a33707951ebf2512d0e759847
tree5b4029519a925734cfb9dc73e929421cb57c7ce0
parent63971b0f51faff0ff844a85d297e27861555c328
efi/libstub: Free correct pointer on failure

cmdline_ptr is an out parameter, which is not allocated by the function
itself, and likely points into the caller's stack.

cmdline refers to the pool allocation that should be freed when cleaning
up after a failure, so pass this instead to free_pool().

Fixes: 42c8ea3dca09 ("efi: libstub: Factor out EFI stub entrypoint ...")
Cc: <stable@vger.kernel.org>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
drivers/firmware/efi/libstub/efi-stub.c