]> git.hungrycats.org Git - linux/commit
media: rc: Ensure registered is cleared in error path
authorSean Young <sean@mess.org>
Fri, 7 Aug 2026 10:50:22 +0000 (11:50 +0100)
committerSean Young <sean@mess.org>
Tue, 22 Sep 2026 13:50:16 +0000 (14:50 +0100)
commit37efd09ba2c62e46e3a3a793025c186f8cd1a417
tree639edc1054343f0a6dc435a749a3de6012912586
parent2f35a044d0905bab74060db1a1ac3cda81733c5d
media: rc: Ensure registered is cleared in error path

If rc_register_device() fails, ensure that registered is not set to true.
If lirc_register() succeeded, then userspace could have an open file
descriptor open. This leads to a use-after-free.

lirc_unregister() must be called with registered = false, else there is a
possibility that an fd is open and polling, which would never return
POLLERR unless registered is false.

Note that registered must be changed under dev->lock, many functions
read registered under lock (e.g. lirc_ioctl).

Fixes: dccc0c3ddf8f ("media: rc: fix race between unregister and urb/irq callbacks")
Signed-off-by: Sean Young <sean@mess.org>
Cc: stable@vger.kernel.org
Acked-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/rc/rc-main.c