]> git.hungrycats.org Git - linux/commit
ovl: properly handle large files in ovl_security_fileattr
authorOleksandr Tymoshenko <ovt@google.com>
Wed, 30 Oct 2024 00:28:55 +0000 (00:28 +0000)
committerAmir Goldstein <amir73il@gmail.com>
Mon, 11 Nov 2024 09:44:36 +0000 (10:44 +0100)
commit3b6b99ef15ea37635604992ede9ebcccef38a239
tree4def5d49e7f6bb266b80b0eba97869ad668e88b3
parent2d5404caa8c7bb5c4e0435f94b28834ae5456623
ovl: properly handle large files in ovl_security_fileattr

dentry_open in ovl_security_fileattr fails for any file
larger than 2GB if open method of the underlying filesystem
calls generic_file_open (e.g. fusefs).

The issue can be reproduce using the following script:
(passthrough_ll is an example app from libfuse).

  $ D=/opt/test/mnt
  $ mkdir -p ${D}/{source,base,top/uppr,top/work,ovlfs}
  $ dd if=/dev/zero of=${D}/source/zero.bin bs=1G count=2
  $ passthrough_ll -o source=${D}/source ${D}/base
  $ mount -t overlay overlay \
      -olowerdir=${D}/base,upperdir=${D}/top/uppr,workdir=${D}/top/work \
      ${D}/ovlfs
  $ chmod 0777 ${D}/mnt/ovlfs/zero.bin

Running this script results in "Value too large for defined data type"
error message from chmod.

Signed-off-by: Oleksandr Tymoshenko <ovt@google.com>
Fixes: 72db82115d2b ("ovl: copy up sync/noatime fileattr flags")
Cc: stable@vger.kernel.org # v5.15+
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
fs/overlayfs/inode.c