]> git.hungrycats.org Git - linux/commit
btrfs: add a sanity check for btrfs root in btrfs_search_slot()
authorLizhi Xu <lizhi.xu@windriver.com>
Fri, 25 Oct 2024 04:55:53 +0000 (12:55 +0800)
committerDavid Sterba <dsterba@suse.com>
Fri, 29 Nov 2024 15:50:40 +0000 (16:50 +0100)
commit3ed51857a50f530ac7a1482e069dfbd1298558d4
tree812aa6b57915b14c468728b0a76eaf9042330bdc
parented67f2a913a4f0fc505db29805c41dd07d3cb356
btrfs: add a sanity check for btrfs root in btrfs_search_slot()

Syzbot reports a null-ptr-deref in btrfs_search_slot().

The reproducer is using rescue=ibadroots, and the extent tree root is
corrupted thus the extent tree is NULL.

When scrub tries to search the extent tree to gather the needed extent
info, btrfs_search_slot() doesn't check if the target root is NULL or
not, resulting the null-ptr-deref.

Add sanity check for btrfs root before using it in btrfs_search_slot().

Reported-by: syzbot+3030e17bd57a73d39bd7@syzkaller.appspotmail.com
Fixes: 42437a6386ff ("btrfs: introduce mount option rescue=ignorebadroots")
Link: https://syzkaller.appspot.com/bug?extid=3030e17bd57a73d39bd7
CC: stable@vger.kernel.org # 5.15+
Reviewed-by: Qu Wenruo <wqu@suse.com>
Tested-by: syzbot+3030e17bd57a73d39bd7@syzkaller.appspotmail.com
Signed-off-by: Lizhi Xu <lizhi.xu@windriver.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/ctree.c