]> git.hungrycats.org Git - linux/commit
staging: vchiq_arm: Use devm_kzalloc() for vchiq_arm_state allocation
authorUmang Jain <umang.jain@ideasonboard.com>
Wed, 16 Oct 2024 13:02:24 +0000 (18:32 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 19 Oct 2024 08:04:57 +0000 (10:04 +0200)
commit404b739e895522838f1abdc340c554654d671dde
tree878190c831f3933f1353d9bccfcac4773711683e
parent8cf0b93919e13d1e8d4466eb4080a4c4d9d66d7b
staging: vchiq_arm: Use devm_kzalloc() for vchiq_arm_state allocation

The struct vchiq_arm_state 'platform_state' is currently allocated
dynamically using kzalloc(). Unfortunately, it is never freed and is
subjected to memory leaks in the error handling paths of the probe()
function.

To address the issue, use device resource management helper
devm_kzalloc(), to ensure cleanup after its allocation.

Fixes: 71bad7f08641 ("staging: add bcm2708 vchiq driver")
Cc: stable@vger.kernel.org
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20241016130225.61024-2-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c