]> git.hungrycats.org Git - linux/commit
PCI: endpoint: Fix PCI domain ID release in pci_epc_destroy()
authorZijun Hu <quic_zijuhu@quicinc.com>
Thu, 7 Nov 2024 00:53:08 +0000 (08:53 +0800)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Mon, 18 Nov 2024 17:17:05 +0000 (17:17 +0000)
commit4acc902ed3743edd4ac2d3846604a99d17104359
tree6e32a9045a32cc7e0b01aa70f6bc88817fd938a0
parent5089b3d874e9933d9842e90410d3af1520494757
PCI: endpoint: Fix PCI domain ID release in pci_epc_destroy()

pci_epc_destroy() invokes pci_bus_release_domain_nr() to release the PCI
domain ID, but there are two issues:

  - 'epc->dev' is passed to pci_bus_release_domain_nr() which was already
    freed by device_unregister(), leading to a use-after-free issue.

  - Domain ID corresponds to the EPC device parent, so passing 'epc->dev'
    is also wrong.

Fix these issues by passing 'epc->dev.parent' to
pci_bus_release_domain_nr() and also do it before device_unregister().

Fixes: 0328947c5032 ("PCI: endpoint: Assign PCI domain number for endpoint controllers")
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20241107-epc_rfc-v2-1-da5b6a99a66f@quicinc.com
[mani: reworded subject and description]
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Cc: stable@vger.kernel.org
drivers/pci/endpoint/pci-epc-core.c