]> git.hungrycats.org Git - linux/commit
media: adv7604: prevent underflow condition when reporting colorspace
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 15 Oct 2024 10:25:09 +0000 (12:25 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 18 Oct 2024 08:43:03 +0000 (10:43 +0200)
commit50b9fa751d1aef5d262bde871c70a7f44262f0bc
treed3d1c46e6c426d6909356580d01d94cf81a40773
parent576a307a7650bd544fbb24df801b9b7863b85e2f
media: adv7604: prevent underflow condition when reporting colorspace

Currently, adv76xx_log_status() reads some date using
io_read() which may return negative values. The current logic
doesn't check such errors, causing colorspace to be reported
on a wrong way at adv76xx_log_status(), as reported by Coverity.

If I/O error happens there, print a different message, instead
of reporting bogus messages to userspace.

Fixes: 54450f591c99 ("[media] adv7604: driver for the Analog Devices ADV7604 video decoder")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/i2c/adv7604.c