]> git.hungrycats.org Git - linux/commit
iio: gts: fix infinite loop for gain_to_scaletables()
authorZicheng Qu <quzicheng@huawei.com>
Thu, 31 Oct 2024 01:46:26 +0000 (01:46 +0000)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 31 Oct 2024 21:49:26 +0000 (21:49 +0000)
commit7452f8a0814bb73f739ee0dab60f099f3361b151
tree5deb8f74e03c86fd0c0b10b71e8ba819a0037b4d
parente2fb2f89faf87b681038475d093214f4cbe12ebb
iio: gts: fix infinite loop for gain_to_scaletables()

In iio_gts_build_avail_time_table(), it is checked that gts->num_itime is
non-zero, but gts->num_itime is not checked in gain_to_scaletables(). The
variable time_idx is initialized as gts->num_itime - 1. This implies that
time_idx might initially be set to -1 (0 - 1 = -1). Consequently, using
while (time_idx--) could lead to an infinite loop.

Cc: stable@vger.kernel.org # v6.6+
Fixes: 38416c28e168 ("iio: light: Add gain-time-scale helpers")
Signed-off-by: Zicheng Qu <quzicheng@huawei.com>
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Link: https://patch.msgid.link/20241031014626.2313077-1-quzicheng@huawei.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/industrialio-gts-helper.c