]> git.hungrycats.org Git - linux/commit
NFSD: Prevent a potential integer overflow
authorChuck Lever <chuck.lever@oracle.com>
Tue, 17 Sep 2024 16:15:23 +0000 (12:15 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 11 Nov 2024 18:41:57 +0000 (13:41 -0500)
commit7f33b92e5b18e904a481e6e208486da43e4dc841
treea8d03f484b318e2d87cae2e92194c4d8632bbb1b
parent2d5404caa8c7bb5c4e0435f94b28834ae5456623
NFSD: Prevent a potential integer overflow

If the tag length is >= U32_MAX - 3 then the "length + 4" addition
can result in an integer overflow. Address this by splitting the
decoding into several steps so that decode_cb_compound4res() does
not have to perform arithmetic on the unsafe length value.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Cc: stable@vger.kernel.org
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4callback.c