]> git.hungrycats.org Git - linux/commit
ARM: 9431/1: mm: Pair atomic_set_release() with _read_acquire()
authorLinus Walleij <linus.walleij@linaro.org>
Wed, 23 Oct 2024 12:05:34 +0000 (13:05 +0100)
committerRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Wed, 13 Nov 2024 08:15:23 +0000 (08:15 +0000)
commit93ee385254d53849c01dd8ab9bc9d02790ee7f0e
treea7f915fc8ceae2a2c1c5f541995ef3d13dfff019
parent44e9a3bb76e5f2eecd374c8176b2c5163c8bb2e2
ARM: 9431/1: mm: Pair atomic_set_release() with _read_acquire()

The code for syncing vmalloc memory PGD pointers is using
atomic_read() in pair with atomic_set_release() but the
proper pairing is atomic_read_acquire() paired with
atomic_set_release().

This is done to clearly instruct the compiler to not
reorder the memcpy() or similar calls inside the section
so that we do not observe changes to init_mm. memcpy()
calls should be identified by the compiler as having
unpredictable side effects, but let's try to be on the
safe side.

Cc: stable@vger.kernel.org
Fixes: d31e23aff011 ("ARM: mm: make vmalloc_seq handling SMP safe")
Suggested-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
arch/arm/mm/ioremap.c