]> git.hungrycats.org Git - linux/commit
media: dvb_frontend: don't play tricks with underflow values
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 15 Oct 2024 14:05:16 +0000 (16:05 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 18 Oct 2024 08:43:03 +0000 (10:43 +0200)
commit9883a4d41aba7612644e9bb807b971247cea9b9d
tree9ab5beacc9343aae241ddb37a1c430ac3a6e19b7
parent972e63e895abbe8aa1ccbdbb4e6362abda7cd457
media: dvb_frontend: don't play tricks with underflow values

fepriv->auto_sub_step is unsigned. Setting it to -1 is just a
trick to avoid calling continue, as reported by Coverity.

It relies to have this code just afterwards:

if (!ready) fepriv->auto_sub_step++;

Simplify the code by simply setting it to zero and use
continue to return to the while loop.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/dvb-core/dvb_frontend.c