]> git.hungrycats.org Git - linux/commit
lib: string_helpers: silence snprintf() output truncation warning
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Fri, 1 Nov 2024 20:54:53 +0000 (21:54 +0100)
committerKees Cook <kees@kernel.org>
Sat, 2 Nov 2024 20:08:55 +0000 (13:08 -0700)
commita508ef4b1dcc82227edc594ffae583874dd425d7
treea6619c25d6b0e4c678294953c3a6d390d7519874
parent6c06f6a6b48d7f1756860120d21d5ede72735bf6
lib: string_helpers: silence snprintf() output truncation warning

The output of ".%03u" with the unsigned int in range [0, 4294966295] may
get truncated if the target buffer is not 12 bytes. This can't really
happen here as the 'remainder' variable cannot exceed 999 but the
compiler doesn't know it. To make it happy just increase the buffer to
where the warning goes away.

Fixes: 3c9f3681d0b4 ("[SCSI] lib: add generic helper to print sizes rounded to the correct SI range")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Kees Cook <kees@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Link: https://lore.kernel.org/r/20241101205453.9353-1-brgl@bgdev.pl
Signed-off-by: Kees Cook <kees@kernel.org>
lib/string_helpers.c