]> git.hungrycats.org Git - linux/commit
rtc: st-lpc: Use IRQF_NO_AUTOEN flag in request_irq()
authorJinjie Ruan <ruanjinjie@huawei.com>
Thu, 12 Sep 2024 03:37:27 +0000 (11:37 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 10 Nov 2024 22:01:59 +0000 (23:01 +0100)
commitb6cd7adec0cf03f0aefc55676e71dd721cbc71a8
tree0a89c930da8d63978b5f272bb0859ced0defa3e3
parent5127135f738e3d7513fa416ac65b203698d4192d
rtc: st-lpc: Use IRQF_NO_AUTOEN flag in request_irq()

If request_irq() fails in st_rtc_probe(), there is no need to enable
the irq, and if it succeeds, disable_irq() after request_irq() still has
a time gap in which interrupts can come.

request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when
request IRQ.

Fixes: b5b2bdfc2893 ("rtc: st: Add new driver for ST's LPC RTC")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20240912033727.3013951-1-ruanjinjie@huawei.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-st-lpc.c