]> git.hungrycats.org Git - linux/commit
Revert "ALSA: hda/conexant: Mute speakers at suspend / shutdown"
authorJarosław Janik <jaroslaw.janik@gmail.com>
Wed, 30 Oct 2024 17:18:12 +0000 (18:18 +0100)
committerTakashi Iwai <tiwai@suse.de>
Thu, 31 Oct 2024 15:05:01 +0000 (16:05 +0100)
commitc9363bbb0f68dd1ddb8be7bbfe958cdfcd38d851
treec5296c1c84cfa66eede9e9c9921990fbb4273a13
parente49370d769e71456db3fbd982e95bab8c69f73e8
Revert "ALSA: hda/conexant: Mute speakers at suspend / shutdown"

Commit 4f61c8fe3520 ("ALSA: hda/conexant: Mute speakers at suspend /
shutdown") mutes speakers on system shutdown or whenever HDA controller
is suspended by PM; this however interacts badly with Thinkpad's ACPI
firmware behavior which uses beeps to signal various events (enter/leave
suspend or hibernation, AC power connect/disconnect, low battery, etc.);
now those beeps are either muted altogether (for suspend/hibernate/
shutdown related events) or work more or less randomly (eg. AC
plug/unplug is only audible when you are playing music at the moment,
because HDA device is likely in suspend mode otherwise).

Since the original bug report mentioned in 4f61c8fe3520 complained about
Lenovo's Thinkpad laptop - revert this commit altogether.

Fixes: 4f61c8fe3520 ("ALSA: hda/conexant: Mute speakers at suspend / shutdown")
Signed-off-by: Jarosław Janik <jaroslaw.janik@gmail.com>
Link: https://patch.msgid.link/20241030171813.18941-2-jaroslaw.janik@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_conexant.c