]> git.hungrycats.org Git - linux/commit
media: v4l2-tpg: prevent the risk of a division by zero
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 16 Oct 2024 09:53:15 +0000 (11:53 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 18 Oct 2024 08:43:03 +0000 (10:43 +0200)
commite6a3ea83fbe15d4818d01804e904cbb0e64e543b
tree35b6f63a63684df5b7779dcc991d4a2c49ed469d
parent4c76f331a9a173ac8fe1297a9231c2a38f88e368
media: v4l2-tpg: prevent the risk of a division by zero

As reported by Coverity, the logic at tpg_precalculate_line()
blindly rescales the buffer even when scaled_witdh is equal to
zero. If this ever happens, this will cause a division by zero.

Instead, add a WARN_ON_ONCE() to trigger such cases and return
without doing any precalculation.

Fixes: 63881df94d3e ("[media] vivid: add the Test Pattern Generator")
Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c