]> git.hungrycats.org Git - linux/commit
rtc: check if __rtc_read_time was successful in rtc_timer_do_work()
authorYongliang Gao <leonylgao@tencent.com>
Fri, 11 Oct 2024 04:31:53 +0000 (12:31 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Mon, 11 Nov 2024 22:10:54 +0000 (23:10 +0100)
commite8ba8a2bc4f60a1065f23d6a0e7cbea945a0f40d
tree4022f1d8d35e30ba19508fe9a3c5cb75672a6aa4
parent00f1bb9b8486bc963211e6c8eae34a1e759efbd1
rtc: check if __rtc_read_time was successful in rtc_timer_do_work()

If the __rtc_read_time call fails,, the struct rtc_time tm; may contain
uninitialized data, or an illegal date/time read from the RTC hardware.

When calling rtc_tm_to_ktime later, the result may be a very large value
(possibly KTIME_MAX). If there are periodic timers in rtc->timerqueue,
they will continually expire, may causing kernel softlockup.

Fixes: 6610e0893b8b ("RTC: Rework RTC code to use timerqueue for events")
Signed-off-by: Yongliang Gao <leonylgao@tencent.com>
Acked-by: Jingqun Li <jingqunli@tencent.com>
Link: https://lore.kernel.org/r/20241011043153.3788112-1-leonylgao@gmail.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/interface.c