From 0c5b8d8a0c82e3ec85588a306f9ae1df55706e4f Mon Sep 17 00:00:00 2001 From: Dave Jones Date: Mon, 6 Sep 2004 23:24:36 -0700 Subject: [PATCH] [PACKET]: Fix deref before NULL check in packet_release() Using the automated source checker at coverity.com, they picked up on some code in packet_release() where a NULL check was done after dereferencing. Patch below. Signed-off-by: Dave Jones Signed-off-by: David S. Miller --- net/packet/af_packet.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 51d0514fd2a7c..1b441a628b718 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -786,11 +786,13 @@ out: static int packet_release(struct socket *sock) { struct sock *sk = sock->sk; - struct packet_opt *po = pkt_sk(sk); + struct packet_opt *po; if (!sk) return 0; + po = pkt_sk(sk); + write_lock_bh(&packet_sklist_lock); sk_del_node_init(sk); write_unlock_bh(&packet_sklist_lock); -- 2.53.0