From 0c68742b772394cd7c79e50edc630baad8b513e0 Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Mon, 10 Mar 2003 07:42:09 -0800 Subject: [PATCH] [PATCH] NCPFS memleak fix Patch from Petr Vandrovec Reported by Oleg Drokin. In NCP_IOC_SETOBJECTNAME handler, we allocated space (newname pointer), copy stuff from userspace to there and then assign userspace pointer to our internal structure, whoops! --- fs/ncpfs/ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ncpfs/ioctl.c b/fs/ncpfs/ioctl.c index f34e38b9dd8b8..3497f67be9246 100644 --- a/fs/ncpfs/ioctl.c +++ b/fs/ncpfs/ioctl.c @@ -440,7 +440,7 @@ outrel: oldprivatelen = server->priv.len; server->auth.auth_type = user.auth_type; server->auth.object_name_len = user.object_name_len; - server->auth.object_name = user.object_name; + server->auth.object_name = newname; server->priv.len = 0; server->priv.data = NULL; /* leave critical section */ -- 2.53.0