From 1a30ac21ca928ef241d8d9ee1f6b47763c700229 Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Tue, 9 Sep 2003 10:20:08 -0700 Subject: [PATCH] [PATCH] ppp devfs oops fix From: Christoph Hellwig PPP leaves the chardev registered even if we're going to fail the modprobe. --- drivers/net/ppp_generic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c index 6b30d5f28c10a..dc9289503534d 100644 --- a/drivers/net/ppp_generic.c +++ b/drivers/net/ppp_generic.c @@ -792,7 +792,7 @@ static struct file_operations ppp_device_fops = { /* Called at boot time if ppp is compiled into the kernel, or at module load time (from init_module) if compiled as a module. */ -int __init ppp_init(void) +static int __init ppp_init(void) { int err; @@ -801,6 +801,8 @@ int __init ppp_init(void) if (!err) { err = devfs_mk_cdev(MKDEV(PPP_MAJOR, 0), S_IFCHR|S_IRUSR|S_IWUSR, "ppp"); + if (err) + unregister_chrdev(PPP_MAJOR, "ppp"); } if (err) -- 2.53.0