From 1e272f7f4be9f650f6d908ae93d7fa108c7d729f Mon Sep 17 00:00:00 2001 From: Jean Delvare Date: Tue, 13 Jan 2004 19:09:15 -0800 Subject: [PATCH] [PATCH] I2C: documentation update > > They should be converted. From module.h: > > /* DEPRECATED: Do not use. */ > > #define MODULE_PARM(var,type) \ > > ... > > Note that realistically, it's not going away in 2.6, so mass migration > doesn't really win anything. However, I never implemented mixing old > and new style in the same module, so if you're adding a parameter, it > makes sense to convert them all. OK, I don't have much time for a mass conversion anyway. Greg, could you please apply the following patch to the "porting-clients" document so that at least the new drivers don't need to be converted afterwards? --- Documentation/i2c/porting-clients | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/i2c/porting-clients b/Documentation/i2c/porting-clients index fab37c46bbca1..62f32e7247bc4 100644 --- a/Documentation/i2c/porting-clients +++ b/Documentation/i2c/porting-clients @@ -92,7 +92,10 @@ Technical changes: i2c_get_clientdata(client) instead. * [Interface] Init function should not print anything. Make sure - there is a MODULE_LICENSE() line. + there is a MODULE_LICENSE() line. MODULE_PARM() is replaced + by module_param(). Note that module_param has a third parameter, + that you should set to 0 by default. See include/linux/moduleparam.h + for details. Coding policy: -- 2.53.0