From 282ed0030c6f27691a59ebadd206f96a056a4ceb Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Mon, 29 Dec 2003 05:48:33 -0800 Subject: [PATCH] [PATCH] Remove CLONE_FILES from init kernel thread creation From: James Morris The patch below removes the CLONE_FILES flag from the kernel_thread() call which starts init. This is to prevent other kernel threads from sharing file descriptors opened by init (try 'lsof /dev/initctl' on a 2.6 system :-). The reason this patch is being proposed is so that usermode helper apps launched via kernel threads (e.g. modprobe, hotplug) do not then inherit any such file descriptors. This is not a problem in itself so far (other than being messy), but it is a problem for SELinux, which will otherwise need to grant access to /dev/initctl by modprobe and hotplug, a somewhat undesirable scenario. As far as I can tell, there is no reason why init needs to be spawned with CLONE_FILES. Please let me know if there are any objections to the change, which I would like to propose for 2.6.0+ as a cleanup. --- init/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/main.c b/init/main.c index 78536ea28c9f1..c26c0751c69f2 100644 --- a/init/main.c +++ b/init/main.c @@ -375,7 +375,7 @@ static void __init smp_init(void) static void rest_init(void) { - kernel_thread(init, NULL, CLONE_KERNEL); + kernel_thread(init, NULL, CLONE_FS | CLONE_SIGHAND); unlock_kernel(); cpu_idle(); } -- 2.53.0