From 2d7b390ca689a3b18d0612627f76748e23d64975 Mon Sep 17 00:00:00 2001 From: Patrick McHardy Date: Mon, 9 Aug 2004 02:53:43 -0700 Subject: [PATCH] [PKT_SCHED]: Disable local bh's when grabbing qdisc_tree_lock in tc_dump_tfilter. I missed this one when fixing locking in __qdisc_destroy. Signed-off-by: Patrick McHardy Signed-off-by: David S. Miller --- net/sched/cls_api.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 9026a9ec9135d..e76951381194d 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -387,7 +387,7 @@ static int tc_dump_tfilter(struct sk_buff *skb, struct netlink_callback *cb) if ((dev = dev_get_by_index(tcm->tcm_ifindex)) == NULL) return skb->len; - read_lock(&qdisc_tree_lock); + read_lock_bh(&qdisc_tree_lock); if (!tcm->tcm_parent) q = dev->qdisc_sleeping; else @@ -444,7 +444,7 @@ errout: if (cl) cops->put(q, cl); out: - read_unlock(&qdisc_tree_lock); + read_unlock_bh(&qdisc_tree_lock); dev_put(dev); return skb->len; } -- 2.53.0