From 36c72ca250ea690f5ba28c9d582fb12543011d73 Mon Sep 17 00:00:00 2001 From: Jens Axboe Date: Sun, 5 Oct 2003 18:06:13 -0700 Subject: [PATCH] [PATCH] check copy_from_user return value in sony535 From: Felipe W Damasio Found by smatch. --- drivers/cdrom/sonycd535.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/cdrom/sonycd535.c b/drivers/cdrom/sonycd535.c index a763f096e59d5..1d55bf861c7bb 100644 --- a/drivers/cdrom/sonycd535.c +++ b/drivers/cdrom/sonycd535.c @@ -1070,7 +1070,6 @@ cdu_ioctl(struct inode *inode, Byte cmd_buff[10], params[10]; int i; int dsc_status; - int err; if (check_drive_status() != 0) return -EIO; @@ -1153,12 +1152,10 @@ cdu_ioctl(struct inode *inode, break; case CDROMPLAYMSF: /* Play starting at the given MSF address. */ - err = verify_area(VERIFY_READ, (char *)arg, 6); - if (err) - return err; + if (copy_from_user(params, (void *)arg, 6)) + return -EFAULT; spin_up_drive(status); set_drive_mode(SONY535_AUDIO_DRIVE_MODE, status); - copy_from_user(params, (void *)arg, 6); /* The parameters are given in int, must be converted */ for (i = 0; i < 3; i++) { -- 2.53.0