From 3d61e3dfa1642f7652ae721fcb70cd417b3f8072 Mon Sep 17 00:00:00 2001 From: Michael Hunold Date: Tue, 13 Jul 2004 19:27:38 -0700 Subject: [PATCH] [PATCH] fix return codes after i2c_add_driver() in tea6415c and tea6420 In two of my i2c helper drivers the return value of i2c_add_driver() is ignored. Thanks to Arthur Othieno for finding these bugs. Signed-off-by: Arthur Othieno Signed-off-by: Michael Hunold Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- drivers/media/video/tea6415c.c | 7 +++---- drivers/media/video/tea6420.c | 7 +++---- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/media/video/tea6415c.c b/drivers/media/video/tea6415c.c index 326f12b3c87f6..fe64e64e3e59f 100644 --- a/drivers/media/video/tea6415c.c +++ b/drivers/media/video/tea6415c.c @@ -217,13 +217,12 @@ static struct i2c_driver driver = { .command = tea6415c_command, }; -static int tea6415c_init_module(void) +static int __init tea6415c_init_module(void) { - i2c_add_driver(&driver); - return 0; + return i2c_add_driver(&driver); } -static void tea6415c_cleanup_module(void) +static void __exit tea6415c_cleanup_module(void) { i2c_del_driver(&driver); } diff --git a/drivers/media/video/tea6420.c b/drivers/media/video/tea6420.c index eca45035470ba..93acdc635f67f 100644 --- a/drivers/media/video/tea6420.c +++ b/drivers/media/video/tea6420.c @@ -197,13 +197,12 @@ static struct i2c_driver driver = { .command = tea6420_command, }; -static int tea6420_init_module(void) +static int __init tea6420_init_module(void) { - i2c_add_driver(&driver); - return 0; + return i2c_add_driver(&driver); } -static void tea6420_cleanup_module(void) +static void __exit tea6420_cleanup_module(void) { i2c_del_driver(&driver); } -- 2.53.0