From 58d11a39b4d66c92363ff82a2e7b2283c1dc6bbf Mon Sep 17 00:00:00 2001 From: Jeff Garzik Date: Fri, 5 Dec 2003 07:35:35 -0800 Subject: [PATCH] [PATCH] remove manual driver poisoning of net_device From: Al Viro Such poisoning can cause oopses either because the refcount is not zero when the poisoning occurs, or due to kernel debugging options being enabled. --- drivers/net/pci-skeleton.c | 7 ------- drivers/net/r8169.c | 4 ---- drivers/net/sis190.c | 4 ---- 3 files changed, 15 deletions(-) diff --git a/drivers/net/pci-skeleton.c b/drivers/net/pci-skeleton.c index 75f2da5c3928e..b671d8c9a84f1 100644 --- a/drivers/net/pci-skeleton.c +++ b/drivers/net/pci-skeleton.c @@ -864,13 +864,6 @@ static void __devexit netdrv_remove_one (struct pci_dev *pdev) pci_release_regions (pdev); -#ifndef NETDRV_NDEBUG - /* poison memory before freeing */ - memset (dev, 0xBC, - sizeof (struct net_device) + - sizeof (struct netdrv_private)); -#endif /* NETDRV_NDEBUG */ - free_netdev (dev); pci_set_drvdata (pdev, NULL); diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 10f43aaf222dc..fdc2ef5567dea 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -642,10 +642,6 @@ rtl8169_remove_one(struct pci_dev *pdev) iounmap(tp->mmio_addr); pci_release_regions(pdev); - // poison memory before freeing - memset(dev, 0xBC, - sizeof (struct net_device) + sizeof (struct rtl8169_private)); - pci_disable_device(pdev); free_netdev(dev); pci_set_drvdata(pdev, NULL); diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index da4ea1b59eaa8..369f8e7dfe8f5 100644 --- a/drivers/net/sis190.c +++ b/drivers/net/sis190.c @@ -703,10 +703,6 @@ SiS190_remove_one(struct pci_dev *pdev) iounmap(tp->mmio_addr); pci_release_regions(pdev); - // poison memory before freeing - memset(dev, 0xBC, - sizeof (struct net_device) + sizeof (struct sis190_private)); - free_netdev(dev); pci_set_drvdata(pdev, NULL); } -- 2.53.0