From 59debc62e781e7eb7286aa970a927d52b9609cb8 Mon Sep 17 00:00:00 2001 From: Russell King Date: Sat, 24 Jan 2004 21:23:50 +0000 Subject: [PATCH] [SERIAL] Fix missing NULL check tty->driver_data or state->port may end up being NULL in uart_close. Make sure that we correctly clean up in this case, rather than oopsing. --- drivers/serial/serial_core.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c index c0fbca8849b77..3f403b5e5816b 100644 --- a/drivers/serial/serial_core.c +++ b/drivers/serial/serial_core.c @@ -1208,9 +1208,15 @@ static void uart_set_termios(struct tty_struct *tty, struct termios *old_termios static void uart_close(struct tty_struct *tty, struct file *filp) { struct uart_state *state = tty->driver_data; - struct uart_port *port = state->port; + struct uart_port *port; BUG_ON(!kernel_locked()); + + if (!state || !state->port) + return; + + port = state->port; + DPRINTK("uart_close(%d) called\n", port->line); down(&state->sem); -- 2.53.0